Quiet optimized dependency sourcemap warnings#4646
Draft
Conversation
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 5h 13m 51s ⏱️ Results for commit dffbbca. Realm Server Test Results 1 files 1 suites 18m 18s ⏱️ Results for commit dffbbca. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Vite dev-server middleware in packages/host to patch optimized dependency sourcemaps on the fly so Vite stops emitting repeated sourcemap warnings during pnpm start.
Changes:
- Adds a serve-only Vite plugin that intercepts optimized dependency requests under
node_modules/.vite/deps. - Reads matching
.js.mapfiles and pads missingsourcesContententries before Vite continues serving the dependency. - Wires the new middleware into the host app’s Vite plugin list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+123
to
+129
| server.middlewares.use(async (req, _res, next) => { | ||
| try { | ||
| let pathname = decodeURI((req.url ?? '').split('?')[0]); | ||
| if (optimizedDepUrlRE.test(pathname)) { | ||
| let file = path.resolve(server.config.root, pathname.slice(1)); | ||
| if (file.startsWith(`${depsDir}${path.sep}`)) { | ||
| await padOptimizedDepSourcemap(file); |
| let changed = false; | ||
| for (let i = 0; i < map.sources.length; i++) { | ||
| if (sourcesContent[i] == null) { | ||
| sourcesContent[i] = ''; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcesContententries from pnpm package paths outsidepackages/host/node_modules/.vite, which removes the repeated "Sourcemap for ... points to a source file outside its package" warnings.Validation
pnpm startinpackages/hostbefore the change.sourcesContentlength matchessourceslength.mise exec -- pnpm lintinpackages/host.mise exec -- pnpm buildinpackages/host.