Fix feedback returned when get_match_feedback doesn't find a match#13
Open
zeezooz wants to merge 1 commit into
Open
Fix feedback returned when get_match_feedback doesn't find a match#13zeezooz wants to merge 1 commit into
zeezooz wants to merge 1 commit into
Conversation
…ix suggestions for the regex case Now it works like the original.
|
Without this the default feedback keeps getting modified: static Feedback default_feedback = Feedback() // <---------- NOTE: NOT FINAL
..warning = ''
..suggestions = [
"Use a few words, avoid common phrases"
"No need for symbols, digits, or uppercase letters"
];static Feedback get_match_feedback(PasswordMatch match, bool is_sole_match) {
// other cases ...
// default case:
return default_feedback;final extra_feedback = 'Add another word or two. Uncommon words are better.';
if (feedback != null) {
feedback.suggestions!.insert(0, extra_feedback); // <--------- keeps adding this with every run
if (feedback.warning == null) {
feedback.warning = '';
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix suggestions for the regex case.
Now it works like the original.