Expose API in addition to the command-line option#1
Open
colinmathews wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice little utility here.
This PR wraps
deploy.jsin a module and exposes it so that it can be called programmatically.deploy.jscan still be run as a command-line utility.The API uses a standard callback with arguments
(error, result), but for now the error property is always null. Further work could switch and/or catch thrown exceptions and feed them into the error argument (instead of just throwing them).The result to the callback is an object instead of a status so it can easily be extended in the future:
Here's a quick sample of how the call works:
Cheers!