Skip to content

feat: Add OCKHealthKitOutcome to OCKStore - #639

Draft
cbaker6 wants to merge 23 commits into
carekit-apple:mainfrom
cbaker6:asyncUpdates
Draft

feat: Add OCKHealthKitOutcome to OCKStore#639
cbaker6 wants to merge 23 commits into
carekit-apple:mainfrom
cbaker6:asyncUpdates

Conversation

@cbaker6

@cbaker6 cbaker6 commented Jan 29, 2022

Copy link
Copy Markdown
Contributor
  • Renamed OCKObjectCompatible.swift -> OCKVersionedObjectCompatible.swift to match protocol name
  • Made OCKHealthKitOutcome conform to OCKVersionedObjectCompatible
  • Add OCKHealthKitOutcome to OCKEntity

@erik-apple erik-apple left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I’ll look over this soon! Thank you!

@cbaker6

cbaker6 commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

@erik-apple I added some missing properties to OCKHealthKitOutcome. Though some of these aren't used currently, I made them match OCKOutcome as I suspect they will be needed in the future. I didn't physically add OCKHealthKitOutcome to CoreData as I'm guessing there may be another linkage along with more discussion to handle this properly.

I also marked some important properties as internal in the concrete OCK objects. I did this because I believe they were internal before the winter update and they probably shouldn't be manipulated by developers. Let me know if you need me to make some adjustments.

@cbaker6 cbaker6 changed the title add async/await support to iOS 13 updates to OCKHealthKitOutcome Feb 17, 2022
@cbaker6 cbaker6 changed the title updates to OCKHealthKitOutcome feat: Add OCKHealthKitOutcome to OCKStore Feb 24, 2025
@cbaker6
cbaker6 marked this pull request as draft February 24, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants