Update OCKChartController.swift - #649
Open
ikonted wants to merge 1 commit into
Open
Conversation
I would like to add a custom eventQuery as a user
gavirawson-apple
left a comment
gavirawson-apple
left a comment
Collaborator
There was a problem hiding this comment.
This looks great @ikonted! Thanks for the contribution, I think the flexibility of creating a custom event query will make this controller much more helpful.
Since these changes expose a property and an initializer to the public API, would you like to try your hand at documenting the two for future clients? There is some other documentation in this class that can be used as a reference / starting point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to have the option to have a custom event query.