fix: Building package for Swift 6.0 #740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 6.0 doesn’t allow trailing commas.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Swift 6.0 compatibility by removing trailing commas from Package.swift, which are not supported in Swift 6.0 (only in 6.1+).
Changes:
- Removed trailing comma from the CareKitFHIR library product definition
- Removed trailing comma from the CareKitStore target's swiftSettings parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated Xcode version badge from 14.0+ to 16.0+ in README.
cbaker6
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 6.0 doesn’t allow trailing commas. Only 6.1+ supports trailing commas. See SPI build log that attempts to build Swift 6.0: https://swiftpackageindex.com/builds/06F07AA5-9430-469D-B2E7-2BCC1DC511A6