i18n(vi): add Vietnamese (vi) locale#246
Conversation
Adds Vietnamese translation file at src/i18n/locales/vi.ts mirroring the structure of the source English locale, and registers 'vi' in the locale map (src/config/locale.ts) as a work-in-progress language. Closes caret-collective#144 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Thanks for the PR! Couple changes requested:
- The Markdoc files also need to be translated. #144 has the details on how to do this. Make sure to translate image alt text as well
- .bounty_pr.json should be removed
- The build needs to be run locally with
bun run buildto generate the social images in Vietnamese and make sure nothing else is broken. If you need help with this, let me know
Are you able to review Claude's translations yourself (do you speak Vietnamese)?
There was a problem hiding this comment.
Please remove this file
|
Thanks for the review @twocaretcat!
Let me know if you'd prefer to close this PR and reopen scoped per-area, or keep iterating here. |
|
You can keep working here. Feel free to merge or rebase your branch on |
Summary
Adds a Vietnamese translation for the application, addressing #144.
src/i18n/locales/vi.tsmirroring the structure ofen.ts(all required keys:site,icon,alert,header,input,output.map,nav,option.locale,option.general.map,option.lintingRegion,option.theme.map).viinsrc/config/locale.ts: added to theLocaleIdunion and thelocaleMap(markedwip: true,rtl: false), following the same convention used for other in-progress locales (de, es, fr, id, it, zh).${SITE.title}), keeps brand/theme names (AMOLED, Solarized, Gruvbox, Catppuccin, Nord, Dracula, Teal) untranslated, and keeps proper tonal marks throughout.Translation notes
id.ts).Brand + Sáng/Tối, consistent withid.ts.lintingRegionkeeps theautokey mapped to the sharedAUTO_LABEL("Tự động") constant.Closes #144
Test plan
pnpm buildsucceeds with the new locale registered?lang=vi(or the language selector) and confirm Vietnamese strings render with correct tonal marksoption.lintingRegion.unsupportedWarningtooltip displays for Vietnamese (no Harper dialect support yet)🤖 Generated with Claude Code