GameTime.get_wallclocktime() should return a datetime object#1110
Open
Daraan wants to merge 5 commits intocarla-simulator:masterfrom
Open
GameTime.get_wallclocktime() should return a datetime object#1110Daraan wants to merge 5 commits intocarla-simulator:masterfrom
GameTime.get_wallclocktime() should return a datetime object#1110Daraan wants to merge 5 commits intocarla-simulator:masterfrom
Conversation
GameTime.get_wallclocktime() should return a datetime object
Contributor
Author
|
Hey @glopezdiest can we add this. For pyright (and other type checkers that implicitly pick up types) users it will reduce some warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
self.wallclock_t0 = GameTime.get_wallclocktime(), which returns_platform_timestampa type-checker complains that the type used afterwards isint | datetime.datetime, however it is never used asintthis is just the intial value. This minimal PR unifies the type to be always adatetimeobject.Where has this been tested?
Possible Drawbacks
This change is