Push Notifications without Clerk

.github/workflows/ci.yml

@@ -0,0 +1,44 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: oven-sh/setup-bun@v2
+        with:
+          bun-version: latest
+
+      - name: Install dependencies
+        run: bun install --frozen-lockfile
+
+      - name: Run typecheck, lint, and format checks
+        run: bun run check
+
+      - name: Run tests
+        run: bun run test:run
+
+  build:
+    runs-on: ubuntu-latest
+    needs: check
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: oven-sh/setup-bun@v2
+        with:
+          bun-version: latest
+
+      - name: Install dependencies
+        run: bun install --frozen-lockfile
+
+      - name: Build
+        run: bun run build:prod

ATP.md

@@ -0,0 +1,107 @@
+# ATP: Push Notification Migration
+
+## Prerequisites
+
+- Device with existing push notifications enabled
+- Device/browser for new user signup
+- Server deployed with new code
+- Ability to trigger cron job (`/push/deliver-notifications`)
+- Jazz dev tools access
+- `CRON_SECRET` from `.env`
+
+## Trigger Cron Job
+
+```bash
+curl -X GET http://localhost:4321/api/push/deliver-notifications \
+  -H "Authorization: Bearer $CRON_SECRET"
+```
+
+For local testing:
+
+```bash
+curl -X GET http://localhost:4321/api/push/deliver-notifications \
+  -H "Authorization: Bearer $CRON_SECRET"
+```
+
+---
+
+## ATP 1: Existing User Migration
+
+**Goal:** Verify existing users migrate to group-owned settings and continue receiving notifications
+
+### Pre-flight
+
+1. Open Jazz dev tools as existing user with push enabled
+2. Note `notificationSettings` owner (should be Account, not Group)
+
+### Steps
+
+| Step | Action                                                  | Expected                                                                                          |
+| ---- | ------------------------------------------------------- | ------------------------------------------------------------------------------------------------- |
+| 1    | Open app                                                | App loads                                                                                         |
+| 2    | Check browser console                                   | `[Notifications] Migrating to shareable group` → `Migration complete` → `Registration successful` |
+| 3    | Check Jazz dev tools                                    | `notificationSettings` owner is now Group with server as member                                   |
+| 4    | Check `root.notificationSettingsRefs` on server account | Entry exists with your `userId`, recent `lastSyncedAt`, link to your settings                     |
+| 5    | Verify notification settings UI                         | All previously registered devices still visible                                                   |
+| 6    | Trigger cron job                                        | User appears in results, `success: true`                                                          |
+| 7    | Receive push notification                               | Notification arrives on device                                                                    |
+
+### Failure indicators
+
+- Console shows `Migration failed` or `Registration failed`
+- Devices disappeared from settings
+- Server refs list empty or missing user
+- Cron returns no results or `success: false`
+
+---
+
+## ATP 2: New User Push Setup
+
+**Goal:** Verify new users can enable push and receive notifications
+
+| Step | Action                                    | Expected                                         |
+| ---- | ----------------------------------------- | ------------------------------------------------ |
+| 1    | Sign up as new user                       | Account created                                  |
+| 2    | Go to Settings → Notifications            | Page loads                                       |
+| 3    | Enable push notifications, add device     | Device added, success toast                      |
+| 4    | Check console                             | `Registration successful` (no migration message) |
+| 5    | Check server's `notificationSettingsRefs` | New user entry exists                            |
+| 6    | Trigger cron job                          | New user in results                              |
+| 7    | Receive push notification                 | Notification arrives                             |
+
+---
+
+## ATP 3: Re-registration on App Open
+
+**Goal:** Verify `latestReminderDueDate` updates on each app open
+
+| Step | Action                                                                | Expected                                                       |
+| ---- | --------------------------------------------------------------------- | -------------------------------------------------------------- |
+| 1    | As existing user, create reminder for future date (e.g., 2 weeks out) | Reminder created                                               |
+| 2    | Close and reopen app                                                  | App loads                                                      |
+| 3    | Check console                                                         | `Registration successful`                                      |
+| 4    | Check `notificationSettings` in Jazz dev tools                        | `latestReminderDueDate` matches furthest reminder (YYYY-MM-DD) |
+| 5    | Check server ref                                                      | `lastSyncedAt` updated to recent time                          |
+
+---
+
+## ATP 4: Stale Ref Cleanup
+
+**Goal:** Verify inactive users are cleaned up from server refs
+
+| Step | Action                                                                            | Expected                                                              |
+| ---- | --------------------------------------------------------------------------------- | --------------------------------------------------------------------- |
+| 1    | Register a test user                                                              | User in server refs                                                   |
+| 2    | In Jazz dev tools, manually set `lastSyncedAt` to 31+ days ago                    | -                                                                     |
+| 3    | Ensure user has no future reminders (or set `latestReminderDueDate` to past date) | -                                                                     |
+| 4    | Trigger cron                                                                      | Console shows `Marking stale ref for removal`, user removed from refs |
+| 5    | Open app as that user                                                             | Re-registers, back in refs                                            |
+
+---
+
+## Verification Checklist
+
+- [ ] ATP 1: Existing user migration
+- [ ] ATP 2: New user setup
+- [ ] ATP 3: Re-registration updates
+- [ ] ATP 4: Stale cleanup

package.json

@@ -4,8 +4,9 @@
 	"type": "module",
 	"scripts": {
 		"dev": "astro dev",
-		"build": "bun test:run && astro check && astro build",
-		"build:node": "ASTRO_ADAPTER=node astro check && ASTRO_ADAPTER=node astro build",
+		"build": "astro build",
+		"build:prod": "astro build",
+		"build:node": "ASTRO_ADAPTER=node astro build",
 		"preview": "astro preview --port 4322",
 		"preview:node": "ASTRO_ADAPTER=node dotenv -e .env -- astro preview --port 4322",
 		"check": "concurrently -n Astro,Prettier,ESLint \"astro check\" \"prettier --check .\" \"eslint . --ext .ts,.tsx,.js,.jsx,.astro\"",

src/app/features/notification-settings.tsx

@@ -55,6 +55,7 @@ import { PUBLIC_VAPID_KEY } from "astro:env/client"
 import { getServiceWorkerRegistration } from "#app/lib/service-worker"
 import { tryCatch } from "#shared/lib/trycatch"
 import { isInAppBrowser } from "#app/hooks/use-pwa"
+import { triggerNotificationRegistration } from "#app/lib/notification-registration"
 
 export function NotificationSettings({
 	me,
@@ -973,6 +974,21 @@ function AddDeviceDialog({ me, disabled }: AddDeviceDialogProps) {
 			keys: subscriptionResult.data.keys,
 		})
 
+		// Trigger registration with server after adding device
+		if (notifications?.$jazz.id) {
+			let registrationResult = await triggerNotificationRegistration(
+				notifications.$jazz.id,
+			)
+			if (!registrationResult.ok) {
+				toast.warning(t("notifications.toast.registrationFailed"))
+				setOpen(false)
+				form.reset({
+					deviceName: getDeviceName(),
+				})
+				return
+			}
+		}
+
 		toast.success(t("notifications.toast.deviceAdded"))
 		setOpen(false)
 

src/app/hooks/use-register-notifications.test.ts

@@ -0,0 +1,62 @@
+import { describe, test, expect } from "vitest"
+import { findLatestFutureDate } from "#app/lib/reminder-utils"
+
+describe("findLatestFutureDate", () => {
+	let today = "2025-01-15"
+
+	test("returns undefined for empty list", () => {
+		expect(findLatestFutureDate([], today)).toBeUndefined()
+	})
+
+	test("returns undefined when all reminders are in the past", () => {
+		let reminders = [
+			{ dueAtDate: "2025-01-10", deleted: false, done: false },
+			{ dueAtDate: "2025-01-14", deleted: false, done: false },
+		]
+		expect(findLatestFutureDate(reminders, today)).toBeUndefined()
+	})
+
+	test("returns the only future reminder", () => {
+		let reminders = [{ dueAtDate: "2025-01-20", deleted: false, done: false }]
+		expect(findLatestFutureDate(reminders, today)).toBe("2025-01-20")
+	})
+
+	test("returns today's date as valid future", () => {
+		let reminders = [{ dueAtDate: "2025-01-15", deleted: false, done: false }]
+		expect(findLatestFutureDate(reminders, today)).toBe("2025-01-15")
+	})
+
+	test("returns the latest of multiple future reminders", () => {
+		let reminders = [
+			{ dueAtDate: "2025-01-20", deleted: false, done: false },
+			{ dueAtDate: "2025-02-15", deleted: false, done: false },
+			{ dueAtDate: "2025-01-25", deleted: false, done: false },
+		]
+		expect(findLatestFutureDate(reminders, today)).toBe("2025-02-15")
+	})
+
+	test("ignores deleted reminders", () => {
+		let reminders = [
+			{ dueAtDate: "2025-02-15", deleted: true, done: false },
+			{ dueAtDate: "2025-01-20", deleted: false, done: false },
+		]
+		expect(findLatestFutureDate(reminders, today)).toBe("2025-01-20")
+	})
+
+	test("ignores done reminders", () => {
+		let reminders = [
+			{ dueAtDate: "2025-02-15", deleted: false, done: true },
+			{ dueAtDate: "2025-01-20", deleted: false, done: false },
+		]
+		expect(findLatestFutureDate(reminders, today)).toBe("2025-01-20")
+	})
+
+	test("returns undefined when all future reminders are deleted or done", () => {
+		let reminders = [
+			{ dueAtDate: "2025-02-15", deleted: true, done: false },
+			{ dueAtDate: "2025-01-20", deleted: false, done: true },
+			{ dueAtDate: "2025-01-10", deleted: false, done: false },
+		]
+		expect(findLatestFutureDate(reminders, today)).toBeUndefined()
+	})
+})