Fix intermittent 404 error for HL7 lab upload

[Copilot]

• Inspect the HL7 upload gate/test diff and identify the duplicated new-code block Sonar is flagging
• Make the smallest safe refactor to reduce new-code duplication without changing the view-gate behavior
• Run targeted tests/quality checks for the changed files
• Run final validation and reply to the Sonar quality-gate comment

[sourcery-ai]

Sorry @yingbull, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[penify-dev]

Failed to generate code suggestions for PR

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Introduces a dedicated Struts “view gate” action for the HL7 Lab Upload page so that plain GET page loads no longer execute the multipart upload handler, addressing an intermittent 404/error pattern seen when rendering the upload form.

Changes:

• Added ViewInsideLabUpload2Action to gate GET/HEAD access to the HL7 upload JSP behind _lab w.
• Mapped new route lab/CA/ALL/ViewInsideLabUpload in struts-lab.xml and updated multiple navigation links to use it.
• Added a focused unit test covering privilege enforcement and HTTP method gating behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/main/java/io/github/carlos_emr/carlos/lab/gate/ViewInsideLabUpload2Action.java	New GET/HEAD-only gate action enforcing _lab w and blocking non-GET methods.
src/main/webapp/WEB-INF/classes/struts-lab.xml	Adds a new Struts action mapping for the view gate forwarding to testUploader.jsp.
src/main/webapp/WEB-INF/jsp/admin/admin.jsp	Updates HL7 Lab Upload popup link to the new view route.
src/main/webapp/WEB-INF/jsp/administration/leftNav.jspf	Updates admin left-nav HL7 Lab Upload link to the new view route.
src/main/webapp/WEB-INF/jsp/oscarMDS/Index.jsp	Updates HL7 Lab Upload link to open the new view route.
src/main/webapp/WEB-INF/jsp/web/inboxhub/InboxhubTopbar.jsp	Updates topbar HL7 Lab Upload link to the new view route.
src/test/java/io/github/carlos_emr/carlos/lab/gate/ViewInsideLabUpload2ActionTest.java	Adds unit tests for auth/privilege enforcement and 405 handling on POST.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[yingbull]

@copilot apply changes based on the comments in this thread also do your own review on these changes and this issue, is the actual likely cause of the reported behavior fixed, and if not, what else is the cause?

[yingbull]

@copilot adjust the code to meet the quality gate without causing breaking changes. Quality Gate Failed Quality Gate failed

Failed conditions
12.9% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

[Copilot]

@copilot adjust the code to meet the quality gate without causing breaking changes. Quality Gate Failed Quality Gate failed

Failed conditions
...

Adjusted the HL7 upload gate and focused unit test to reduce new-code duplication while preserving the route behavior. Core fix is in 05c402b, with final cleanup in 2815a80. Local lightweight checks passed; Maven test execution is still blocked in the sandbox by external dependency resolution for jitpack.io artifacts.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• build.shibboleth.net
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/carlos/carlos org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=ViewInsideLabUpload2ActionTest (dns block)
• jitpack.io
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/carlos/carlos org.codehaus.plexus.classworlds.launcher.Launcher test -Dtest=ViewInsideLabUpload2ActionTest (dns block)
• sonarcloud.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[yingbull]

@phc007 at your leisure, if you can test this that would be great. If you have a fake hl7 we can get into the test harness or you can send to Ben (Ben@ma.. same as mine) so he can try and run repeated tests with claude or codex on the failure that would be great too. @Ben-Heerema

[phc007]

I can point you to https://github.com/carlos-emr/carlos/tree/develop/src/test/resources/labs for various labs Conformation testing will give you access to Excelelris ON examples note that their labs are XML wrapped HL7 If I have any lying around from my conformance that are wrapped I will upload to source in that directory

…

On Wed, May 20, 2026 at 12:20 PM Michael Yingbull ***@***.***> wrote: *yingbull* left a comment (carlos-emr/carlos#2051) <#2051 (comment)> @phc007 <https://github.com/phc007> at your leisure, if you can test this that would be great. If you have a fake hl7 we can get into the test harness or you can send to Ben ***@***.*** same as mine) so he can try and run repeated tests with claude or codex on the failure that would be great too. @Ben-Heerema <https://github.com/Ben-Heerema> — Reply to this email directly, view it on GitHub <#2051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACURMBLUEDMEHH6BCDGBZC343XLLHAVCNFSM6AAAAACYOW4HLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMBQGQYDOMJUHE> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[phc007]

I have just committed some sample ExcellerisON standard test files including sample PDF embedded in HL7 embedded in XML #2202

…

On Wed, May 20, 2026 at 2:08 PM Peter ***@***.***> wrote: I can point you to https://github.com/carlos-emr/carlos/tree/develop/src/test/resources/labs for various labs Conformation testing will give you access to Excelelris ON examples note that their labs are XML wrapped HL7 If I have any lying around from my conformance that are wrapped I will upload to source in that directory On Wed, May 20, 2026 at 12:20 PM Michael Yingbull < ***@***.***> wrote: > *yingbull* left a comment (carlos-emr/carlos#2051) > <#2051 (comment)> > > @phc007 <https://github.com/phc007> at your leisure, if you can test > this that would be great. If you have a fake hl7 we can get into the test > harness or you can send to Ben ***@***.*** same as mine) so he can try and > run repeated tests with claude or codex on the failure that would be great > too. @Ben-Heerema <https://github.com/Ben-Heerema> > > — > Reply to this email directly, view it on GitHub > <#2051 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACURMBLUEDMEHH6BCDGBZC343XLLHAVCNFSM6AAAAACYOW4HLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMBQGQYDOMJUHE> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> >