-
Notifications
You must be signed in to change notification settings - Fork 66
fix: standardize SecurityException messages to canonical format in encounter and casemgmt actions #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: standardize SecurityException messages to canonical format in encounter and casemgmt actions #3119
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -101,7 +101,7 @@ public String execute() | |||||
| return SUCCESS; | ||||||
|
|
||||||
| } else { | ||||||
| throw new SecurityException("Access Denied!"); //missing required sec object (_admin) | ||||||
| throw new SecurityException("missing required sec object (_admin)") | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win Add the missing semicolon. This Fix- throw new SecurityException("missing required sec object (_admin)")
+ throw new SecurityException("missing required sec object (_admin)");📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
|
|
||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -94,8 +94,7 @@ public String execute() | |||||||||||||||||||
| return "continue"; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| } else { | ||||||||||||||||||||
| throw new SecurityException("Access Denied!"); //missing required sec object (_admin) | ||||||||||||||||||||
| } | ||||||||||||||||||||
| throw new SecurityException("missing required sec object (_admin)"); | ||||||||||||||||||||
| } | ||||||||||||||||||||
|
Comment on lines
96
to
98
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The closing brace
Suggested change
|
||||||||||||||||||||
|
|
||||||||||||||||||||
| /***************************************************************************************** | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,7 +66,6 @@ public String execute() | |
| return "continue"; | ||
|
|
||
| } else { | ||
| throw new SecurityException("Access Denied!"); //missing required sec object (_admin) or (_admin.measurements) | ||
| } | ||
| throw new SecurityException("missing required sec object (_admin)"); | ||
| } | ||
|
Comment on lines
68
to
70
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A semicolon is missing at the end of the statement, which will cause a compilation error.