Disallow more than 1 public method named with regex #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@carlosas Your CI setup seems to be completely broken at the moment; is this something you could take a look at? |
Owner
|
I'll be able to check it on Monday. Sorry but I'm traveling atm |
Right now it is possible to define a class that has two public methods: `exampleOne` and `exampleTwo`. If you do not give this class extra methods and configure the ShouldHaveOnlyOnePublicMethodNamed rule to look for `^example.+$` then it will report success, despite two methods existing with this naming scheme. This rule will only start failing after introducing a method which does *not* follow the naming scheme, e.g. `foo`. This PR aims to fix this by also failing in the `exampleOne` and `exampleTwo` scenario. Note that we interpreted this rule as "can have several public methods, but only one named ...", instead of "should have only one public method *and* it is named ...", so this might not follow the original intention of the rule.
NanoSector
force-pushed
the
bugfix/more-than-one-public-method-named
branch
from
17e4aff to
719f638
Compare
Contributor
Author
|
@carlosas I have updated the branch with the latest master, do you happen to have time to look into this PR? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is possible to define a class that has two public methods:
exampleOneandexampleTwo. If you do not give this class extra methods and configure the ShouldHaveOnlyOnePublicMethodNamed rule to look for^example.+$then it will report success, despite two methods existing with this naming scheme.This rule will only start failing after introducing a method which does not follow the naming scheme, e.g.
foo. This PR aims to fix this by also failing in theexampleOneandexampleTwoscenario.Note that we interpreted this rule as "can have several public methods, but only one named ...", instead of "should have only one public method and it is named ...", so this might not follow the original intention of the rule.