Skip to content

Expose toggle for SchedulesDirect Image downloading and correct base URL #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carlreid
Copy link
Owner

Description

The settings toggles for ENABLE SERIES POSTER ART and ENABLE SERIES WIDE SCREEN ART were exposed on the UI, but all the back-end logic had been commented out. This change now re-enabled just the ENABLE SERIES POSTER ART option, as the ENABLE SERIES WIDE SCREEN ART can probably be controlled by SERIES POSTER ASPECT RATIO(?).

However, this setting was unused currently. So StreamMaster by default was attempting to download the poster/images. The problem was that the URL was not being built correctly, meaning that the content was not downloaded.

Issues (Fixed or Closed)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Toggle on ENABLE SERIES POSTER ART. Should now see program images appearing in EPG (might need to restart StreamMaster to force a sync) sourced from config/Cache/ProgramLogos

Visual Changes

  • Screenshots/videos attached

Dependencies

  • New dependencies added
  • System requirements changed

Checklist

  • I have followed the Conventional Commits naming convention
  • My branch is up to date with the main branch (rebased)
  • My code follows the style guidelines and existing patterns of this project
  • I have performed a self-review of my own code
  • I have commented complex logic
  • I have added tests (if applicable)
  • All tests are passing
  • I have updated documentation as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Schedules Direct Poster Art settings NOT saved.
1 participant