-
Notifications
You must be signed in to change notification settings - Fork 62
Fix for frontend app trying to load /config.json from the root path #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Seems like a GitHub token issue in the PR build. |
Yeh, I didn't get around to fixing it yet as there hasn't been many PRs that aren't from myself.
Definitely not ideal. Though I am not sure if the proposed changes here will work all the time? For instance, loading directly into different client side paths like I'm finding it difficult to find a reliable way to find the path. Though given what
The commits don't follow the conventions. Please do follow them, as the release logic depends on the conventions to understand what kind of version bump is required. |
I've added a new commit, |
Will do.
Thanks for this. Could you tell me what Docker build command you use locally to build? I couldn't figure it out exactly from looking at the various workflow files. |
I don't really bother with Docker. For this, I just ran the Web UI with For testing these changess, I did a Now the PR is open here and built/published, you can also test the changes with the image |
Thanks for the tips. Im using that image now: https://github.com/fbradyirl/streammaster-addon/actions/runs/14810883099/job/41585402632#step:6:389 ![]() but still see the config 404 from root: ![]() |
Not sure if it helps but here is the log:
|
It's web client side, so the logs should appear in the console output within the browser. However by default, only |
d6b8247
to
6fbe620
Compare
Thanks for this. Im still not seeing them im afraid. I think HA is doing something funky to intercept them maybe?
|
Description
The core issue now here that the frontend app in StreamMaster is trying to load /config.json from the root path, which does not work under Home Assistant’s Ingress, where paths are prefixed (like /api/ingress/slug/).
🧠 Root Problem:
This code in settings.ts is not ingress-aware:
request.open("GET", "/config.json", false); // hardcoded path
So in Ingress, it tries to request:
https://<ha-host>/config.json → ❌ 404
Whereas it needs:
https://<ha-host>/api/ingress/slug/editor/config.json → ✅ if served there
Issues (Fixed or Closed)
Type of Change
Dependencies
Checklist
main
branch (rebased)