Make mktemplate also work with project-level template directories#49
Make mktemplate also work with project-level template directories#49haukuri wants to merge 3 commits intocarltongibson:mainfrom
Conversation
app template directories.
|
@carltongibson I couldn't quite figure out how to make the test case for not using an app-level template directory work with the existing unit test structure so I refactored it to more closely resemble a project structure as generated by Would you rather keep the existing structure? If so, could you point me in the right direction towards how to implement the new test within it? |
|
Hi @haukuri.
I would 😅 Could you not (merely) add an |
Doesn't work
27f730a to
081cab3
Compare
|
The current version renames the template directory in the test project so that it does not get picked up as an app template dir. This is not great because now we are not testing the case in which the user is actually using an app template dir. I've also tried to use the I've even tried having both the regular app A solution would be to have a second app in the test project that would not have a template directory so that we would fall back to the project level template dir but I'm not sure how to do that within the test project structure. Perhaps we should just close this PR. You could always do the change to |
|
@haukuri Let me have a play. Thanks. 🙏 |
The
mktemplatemanagement command was not working for project-level template directories. See issue #48.This change updates the
mktemplatehandle function to work for both app and project template directories.