Skip to content

Support AGP 9.x compatibility#491

Open
giaquo wants to merge 1 commit into
carp-dk:mainfrom
giaquo:agp9-compatibility
Open

Support AGP 9.x compatibility#491
giaquo wants to merge 1 commit into
carp-dk:mainfrom
giaquo:agp9-compatibility

Conversation

@giaquo

@giaquo giaquo commented May 20, 2026

Copy link
Copy Markdown

Starting with Android Gradle Plugin 9.0, Kotlin support is embedded in
AGP itself and applying the standalone kotlin-android plugin causes a
build failure.

This PR detects the AGP version and skips both the plugin application
and the kotlinOptions block when running on AGP 9 or above, keeping
the existing behavior unchanged for AGP 8.x and below.

Same approach used by file_picker
since version 10.x.

ytsni added a commit to ytsni/health_bridge that referenced this pull request May 24, 2026
Cherry-picked and combined fixes from upstream PRs:

- carp-dk#484: Remove TOTAL_CALORIES_BURNED from iOS dataTypeKeys (SIGABRT crash)
- carp-dk#461: Make distance/energy/steps reads optional when fetching workouts
  (fixes silent empty list + Play Store permission rejection)
- carp-dk#458: Replace Handler(mainLooper) with coroutine dispatchers, parallelize
  workout metric queries (fixes ANRs)
- carp-dk#459: Add try/catch to Health Connect operations (rate limit crash fix)
- carp-dk#477: Add BIKING_STATIONARY mapping for Health Connect
- carp-dk#491: AGP 9.x compatibility (conditional kotlin-android plugin)
- carp-dk#492: Fix workoutSummary always null on Android (accept both camelCase
  and snake_case keys from native layer)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ytsni added a commit to ytsni/health_bridge that referenced this pull request May 24, 2026
Cherry-picked and combined fixes from upstream PRs:

- carp-dk#484: Remove TOTAL_CALORIES_BURNED from iOS dataTypeKeys (SIGABRT crash)
- carp-dk#461: Make distance/energy/steps reads optional when fetching workouts
  (fixes silent empty list + Play Store permission rejection)
- carp-dk#458: Replace Handler(mainLooper) with coroutine dispatchers, parallelize
  workout metric queries (fixes ANRs)
- carp-dk#459: Add try/catch to Health Connect operations (rate limit crash fix)
- carp-dk#477: Add BIKING_STATIONARY mapping for Health Connect
- carp-dk#491: AGP 9.x compatibility (conditional kotlin-android plugin)
- carp-dk#492: Fix workoutSummary always null on Android (accept both camelCase
  and snake_case keys from native layer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant