Conversation
…ce/issue-14 Translate og code python -> R
Made a few change on removing VSCode Terminal.
Update ls output. Add -F. Add ls command to see ".git". Update git status to R file.
Edit section with first commits, and add/edit some explanatory text.
update ls -laF files to match after creating project. Edit more lines.
Update section with filename changes and code change.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. It should be safe to Approve and Run the workflows that need maintainer approval. |
Revise ls output as sometimes. `.DStore` does not always show up to removed from `ls` and `git` commands. ADDED a section to add `.gitignore` with `echo` as was done in the Python version (avoids any editor issues.) I will open an ISSUE about running the code regarding `library(lubridate)`.
Added a code update moving the `library(lubridate)` one line up so that the code functions. Look at files created. Update git status.
Added a git status and its clean output
fixed challenge and solution close tags with colons ::: etc
|
(Copy of comment I mistakenly had added to my own branch) IMPORTANT ADDITION made to the episode:
IMPORTANT ADDITION: I also moved the I made these decision along the way as they seemed the best way to approach the changes and differences with the Python version. |
katrinabrock
left a comment
There was a problem hiding this comment.
Added some early feedback on what you have here thus far.
|
|
||
| But which Vignette can help us? | ||
|
|
||
| If we look 2 lines below the error line in `eva_data_analysis.R` , we can note that the line `library(lubridate)` calls a name that matches a Vignette. It seems that the function `Date()` was called before the library was requested. |
There was a problem hiding this comment.
Two questions:
- Do we need lubridate here, or can we just use
as.Datefrom base R? - ??Date will only work if
lubridateis already installed. Can we assume that's the case at this point?
Co-authored-by: Brock <keb266@cornell.edu>
sstevens2
left a comment
There was a problem hiding this comment.
I did a quick review of some of the changes needed. I'll start working on implementing the ones I can.
Note, I believe this branch still needs to be rebased to main. I think the only changes are in the episode 2 but it shows multiple files because of the previous rebase of main.
| ```bash | ||
| $ echo ".Rproj.user" > .gitignore | ||
| $ echo ".gitignore" >> .gitignore | ||
| ``` |
There was a problem hiding this comment.
I recommend they build the gitignore themselves and we add a spoiler or callout to mention that github has a generic R gititnore that can be helpful
Co-authored-by: Brock <keb266@cornell.edu>
based on suggestion by @katrinabrock
|
Closed with preference to #38 |
Edited at least the top half of Episode 2 to change from Python to R (.e.g. change
.pytoR; change VS Code to RStudio).I have not yet changed the Instructor panels about VS Code.
Other changes:
spacewalks.Rprojto the first series ofgit add.-Fwhen usinglsto clearly show what is a directory vs a file.@presence inls -laFcommand.DS_StoreRSCRIPTSuggestion for next edit: move the creation of
.gitignoreto this episode as we have at least one dot file due to R:.Rproj.userand Mac users will also have.DS_Store. Also, I noted that when updating theeva_data_analysis.Rscript.gitignoreis created automatically. So we can wait for that to happen, or preempt and create it before running the script.