Skip to content

Reword error in test concept 06-code-correctness.md#331

Merged
anenadic merged 1 commit intocarpentries-incubator:mainfrom
katrinabrock:patch-2
Nov 21, 2025
Merged

Reword error in test concept 06-code-correctness.md#331
anenadic merged 1 commit intocarpentries-incubator:mainfrom
katrinabrock:patch-2

Conversation

@katrinabrock
Copy link
Contributor

for more technical accuracy. I'm pretty sure it this case, the assertion is not evaluated at all to True or False as the function being called never returns.

for more technical accuracy.  I'm pretty sure it this case, the assertion is not evaluated at all to True or False as the function being called never returns.
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/better-research-software/compare/md-outputs..md-outputs-PR-331

The following changes were observed in the rendered markdown documents:

 06-code-correctness.md | 2 +-
 md5sum.txt             | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-11-21 10:40:26 +0000

github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
@anenadic
Copy link
Collaborator

@steve-crouch would you be able to review this PR (as you are going to be teaching this next week)?

@anenadic anenadic merged commit 84eef95 into carpentries-incubator:main Nov 21, 2025
3 checks passed
@anenadic
Copy link
Collaborator

Thank you @katrinabrock.

github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
Auto-generated via `{sandpaper}`
Source  : 84eef95
Branch  : main
Author  : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time    : 2025-11-21 16:30:49 +0000
Message : Merge pull request #331 from katrinabrock/patch-2

Reword error in test concept 06-code-correctness.md
github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
Auto-generated via `{sandpaper}`
Source  : 90b41da
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-11-21 16:31:37 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 84eef95
Branch  : main
Author  : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time    : 2025-11-21 16:30:49 +0000
Message : Merge pull request #331 from katrinabrock/patch-2

Reword error in test concept 06-code-correctness.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants