Fixed formula for total power consumption calculation from knowing compute node power consumption#5
Open
abaer-kit wants to merge 1 commit intocarpentries-incubator:mainfrom
Open
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. It should be safe to Approve and Run the workflows that need maintainer approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
there is some minor inconsistency in the calculation of the total energy calculation.
If taking 85% of the total energy as baseline, on has to add 17.65...% ~ 18% to it to reach the total of 100%:
0.85 + (0.180.85) = 1.003
0.85 + (0.150.85) = 0.978
Further, it might be required to explain the 18% (e.g. with the above formula) to prevent possible confusion.
Alternatively, one could rephrase the sentence to clarify this.
Best,
Andreas