-
-
Notifications
You must be signed in to change notification settings - Fork 33
[WIP] Initial commit of updated workflows #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
froggleston
wants to merge
74
commits into
carpentries:main
Choose a base branch
from
froggleston:docker_workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto docker_workflows
Merge upstream
…nto docker_workflows
…nto docker_workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer QOL 👷
This feature enhances the developer quality of life
enhancement
New feature or request
frequency: high
indicator that a use-case has a high-frequency in lessons
package cache
Related to the {renv} package cache
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fairly consequential update to the sandpaper workflows. The main provisions are:
SANDPAPER_WORKFLOWPAT #646 (thanks @Bisaloo!)renv::restorethe same cached renv environment for each build rather than updating packages whether intended or not viaremotes::install()andsandpaper::manage_deps().Testing needs to be done, and then a formal mechanism to switch to the new dockerised versions, presumably by replacing the existing workflow files, and using the existing update-workflows mechanism to propagate through user's repos.
What left to do:
Documentation for testing:
Clone froggleston's sandpaper and switch to the docker_workflows branch:
cd ~mkdir ~/docker-testcd docker-testgit clone https://github.com/froggleston/sandpapercd sandpapergit switch docker_workflowsswcarpentry/git-novicein the github web interface to<your_github>/git-novicemkdir ~/lessonscd ~/lessonsgit clone <your_github>/git-noviceRinstall.packages("devtools")devtools::install("~/docker-test/sandpaper")sandpaper::update_github_workflows()quit()git add .github/workflowsgit commit -m "Manual update to docker workflows"git push origin mainThis will automatically start the
01 Maintain: Build and Deploy Siteworkflow. This will work for non-renv lessons. For renv-enabled lessons:If packages were updated and a PR raised, the subsequent "03 Maintain: Apply Package Cache" and "01 Maintain: Build and Deploy Site" workflows should run automatically.
If no updates were made, run "03 Maintain: Apply Package Cache" manually, and then "01 Maintain: Build and Deploy Site" will run automatically.