Skip to content

Revert "fix(cli): keep evm-reader enabled" #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: prerelease/v2-alpha
Choose a base branch
from

Conversation

endersonmaia
Copy link
Contributor

This reverts commit 2949c51.


My last understanding of this is that, when we enable --services espresso we should disable CARTESI_FEATURE_INPUT_READER_ENABLED.

Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 5269ae9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 27.16% 295 / 1086
🔵 Statements 27.1% 300 / 1107
🔵 Functions 26.56% 51 / 192
🔵 Branches 24.84% 121 / 487
File CoverageNo changed files found.
Generated in workflow #512 for commit 5269ae9 by the Vitest Coverage Report Action

@tuler
Copy link
Member

tuler commented May 20, 2025

In theory we don't need to disable it.
Because the node is programmed to ignore espresso applications, and the espresso reader should be ignoring non-espresso applications.
We need to test this, and avoid disabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants