Simplify remote machine logs#387
Open
diegonehab wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since Boost 1.79,
boost::system::error_code::what()appends asource_locationsuffix (file, line, column, fulltemplate-expanded function signature) when the error code was constructed with location data.
Asio constructs all its error codes this way, so every network error log in
cartesi-jsonrpc-machine(read request,send response, accept) includes hundreds of characters of Boost internals regardless of the configured log level.
Solution
Added a file-local
format_ec()helper that returnsec.what()(verbose) when the runtime log level istraceordebug, andec.message()(plain message only) otherwise.Replaced
ec.what()withformat_ec(ec)at all three affected SLOG sites insrc/jsonrpc-remote-machine.cpp.Fixes #381.