handle error #59

ZzzzHui · 2025-05-15T04:15:53Z

No description provided.

fabiooshiro · 2025-05-28T13:23:15Z

internal/espressoreader/espresso_reader.go

-							lastProcessedL1Block, l1FinalizedTimestamp = e.readL1(ctx, app, currentEspressoBlockHeight, lastProcessedL1Block)
+							lastProcessedL1Block, l1FinalizedTimestamp, err = e.readL1(ctx, app, currentEspressoBlockHeight, lastProcessedL1Block)
+							if err != nil {
+								slog.Error("failed reading L1", "error", err)


is it ok to just skip?

you're right. This should be a break

Copilot

Pull Request Overview

Updates error handling across EVM and Espresso readers to return and propagate errors, and improves HTTP handlers to send appropriate responses.

Changed EvmReader to return errors instead of swallowing them
Enhanced EspressoReaderService endpoints to write HTTP error responses and close request bodies
Refactored EspressoReader to propagate errors from readL1 and stop silent skips in readEspresso

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
internal/evmreader/input.go	Return wrapped errors on repository failures instead of logging and continuing
internal/espressoreader/espressoreader_service.go	Send HTTP error responses, set Content-Type, and close request bodies
internal/espressoreader/espresso_reader_unit_test.go	Decode test input with hex.DecodeString instead of hardcoded bytes
internal/espressoreader/espresso_reader.go	Propagate errors from readL1 and adjust readEspresso loop control

Comments suppressed due to low confidence (2)

internal/espressoreader/espressoreader_service.go:191

Ensure the request body is closed in the submit handler by adding defer r.Body.Close() immediately after entry.

body, err := io.ReadAll(r.Body)

internal/espressoreader/espresso_reader_unit_test.go:919

Avoid ignoring the error from hex.DecodeString; handle or assert it, e.g., inputData, err := hex.DecodeString(...); require.NoError(err).

inputData, _ := hex.DecodeString("69689578...0000")

Copilot · 2025-05-28T13:30:37Z

internal/evmreader/input.go

@@ -153,19 +153,23 @@ func (r *EvmReader) ReadAndStoreInputs(
 			combinedIndex, err := r.repository.GetInputIndexWithTx(ctx, dbTx, address.Hex())
 			if err != nil {
 				slog.Error("evmreader: failed to read index", "app", address, "error", err)
+				return errors.New("evmreader: failed to read index")


Wrap and return the original error to preserve context, e.g., fmt.Errorf("evmreader: failed to read index: %w", err).

Suggested change

return errors.New("evmreader: failed to read index")

return fmt.Errorf("evmreader: failed to read index: %w", err)

This change doesn't seem necessary

This change doesn't seem necessary

The only drawback here is that the original error is not preserved in the tracker.

The original error message is printed as error message. So should be fine

Copilot · 2025-05-28T13:30:37Z

internal/evmreader/input.go

-					input.RawData = modifiedRawData
+				if err != nil {
+					slog.Error("evmreader: failed to modify index", "app", address, "error", err)
+					return errors.New("evmreader: failed to modify index")


Wrap the original error when returning, e.g., fmt.Errorf("evmreader: failed to modify index: %w", err).

Suggested change

return errors.New("evmreader: failed to modify index")

return fmt.Errorf("evmreader: failed to modify index: %w", err)

Copilot · 2025-05-28T13:30:38Z

internal/evmreader/input.go

 			}
 			// update input index
 			err = r.repository.UpdateInputIndexWithTx(ctx, dbTx, address.Hex())
 			if err != nil {
 				slog.Error("failed to update index", "app", address, "error", err)
+				return errors.New("evmreader: failed to update index")


Wrap the repository error to keep the original error context, e.g., fmt.Errorf("evmreader: failed to update index: %w", err).

Suggested change

return errors.New("evmreader: failed to update index")

return fmt.Errorf("evmreader: failed to update index: %w", err)

Copilot · 2025-05-28T13:30:38Z

internal/evmreader/input.go

@@ -201,15 +205,13 @@ func (r *EvmReader) ReadAndStoreInputs(
 				"address", address,
 				"error", err,
 			)
-			dbTx.Rollback(ctx)
-			continue
+			return errors.New("evmreader: Error storing inputs and epochs")


Use consistent lowercase for error messages and wrap the original error, e.g., fmt.Errorf("evmreader: error storing inputs and epochs: %w", err).

Suggested change

return errors.New("evmreader: Error storing inputs and epochs")

return fmt.Errorf("evmreader: error storing inputs and epochs: %w", err)

Copilot · 2025-05-28T13:30:38Z

internal/espressoreader/espressoreader_service.go

@@ -107,18 +107,24 @@ func (s *EspressoReaderService) requestNonce(w http.ResponseWriter, r *http.Requ
 	w.Header().Set("Access-Control-Allow-Origin", "*")
 	w.Header().Set("Access-Control-Allow-Headers", "Access-Control-Allow-Headers, Origin,Accept, X-Requested-With, Content-Type, Access-Control-Request-Method, Access-Control-Request-Headers")
 	if r.Method != http.MethodPost {
+		w.WriteHeader(http.StatusMethodNotAllowed)


Set the Content-Type header before writing JSON, e.g., w.Header().Set("Content-Type", "application/json").

Suggested change

w.WriteHeader(http.StatusMethodNotAllowed)

w.WriteHeader(http.StatusMethodNotAllowed)

w.Header().Set("Content-Type", "application/json")

Copilot · 2025-05-28T13:30:38Z

internal/espressoreader/espresso_reader.go

@@ -441,7 +454,7 @@ func (e *EspressoReader) readEspresso(ctx context.Context, appEvmType evmreader.
 		)
 		if err != nil {
 			slog.Error("could not store Espresso input", "err", err)
-			continue
+			return


Returning here exits the entire readEspresso loop instead of skipping the failed log; consider using continue or returning an error to the caller.

Suggested change

return

continue

no. The loop should be exited

no. The loop should be exited

In Go, it's common practice to return the error to the caller rather than relying on nil.
You can return the error itself if needed.

fabiooshiro · 2025-05-28T13:34:18Z

❤️ @Copilot

ZzzzHui force-pushed the feature/handle-error branch 2 times, most recently from eb13388 to e0d8004 Compare May 16, 2025 04:58

ZzzzHui marked this pull request as ready for review May 16, 2025 04:59

ZzzzHui requested review from fabiooshiro and miltonjonat May 16, 2025 05:00

handle error

38d46db

ZzzzHui force-pushed the feature/handle-error branch from e0d8004 to 38d46db Compare May 16, 2025 07:39

miltonjonat mentioned this pull request May 21, 2025

alchemy free tier #60

Merged

fabiooshiro reviewed May 28, 2025

View reviewed changes

sandhilt requested a review from Copilot May 28, 2025 13:28

Copilot AI reviewed May 28, 2025

View reviewed changes

fix error handling

7ee199f

ZzzzHui requested review from fabiooshiro and sandhilt May 30, 2025 23:54

sandhilt approved these changes Jun 3, 2025

View reviewed changes

ZzzzHui merged commit 1357f07 into main Jun 3, 2025
4 checks passed

ZzzzHui deleted the feature/handle-error branch June 3, 2025 16:22

	return errors.New("evmreader: failed to read index")
	return fmt.Errorf("evmreader: failed to read index: %w", err)

	return errors.New("evmreader: Error storing inputs and epochs")
	return fmt.Errorf("evmreader: error storing inputs and epochs: %w", err)

	w.WriteHeader(http.StatusMethodNotAllowed)
	w.WriteHeader(http.StatusMethodNotAllowed)
	w.Header().Set("Content-Type", "application/json")

handle error #59

handle error #59

Uh oh!

Conversation

ZzzzHui commented May 15, 2025

Uh oh!

fabiooshiro May 28, 2025

Choose a reason for hiding this comment

Uh oh!

ZzzzHui May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

ZzzzHui May 30, 2025

Choose a reason for hiding this comment

Uh oh!

sandhilt Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

ZzzzHui Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 28, 2025

Choose a reason for hiding this comment

Uh oh!

ZzzzHui May 30, 2025

Choose a reason for hiding this comment

Uh oh!

sandhilt Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

fabiooshiro commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!