Add preliminary support for PHP 5.4 #43
Conversation
There was a problem hiding this comment.
I'm fine with this approach, but I believe we should define the minimum PHP versions we officially support:
>= 7.4: This version is well-tested and reliable with Mago.>= 5.4: This can be allowed, but with caution.
The reasoning is that PHP 7 and PHP 8 introduced significant changes, particularly around operator precedence and associativity (left, right, or none). While Mago ( esp. the parser ) might work with your codebase, it could potentially fail or behave unexpectedly with others.
| impl Rule for FinallyFeatureRule { | ||
| fn get_definition(&self) -> RuleDefinition { | ||
| RuleDefinition::enabled("Finally Feature", Level::Error) | ||
| .with_maximum_supported_php_version(PHPVersion::PHP54) |
There was a problem hiding this comment.
| .with_maximum_supported_php_version(PHPVersion::PHP54) | |
| .with_maximum_supported_php_version(PHPVersion::PHP55) |
this has became exlusive now.
| .with_annotation( | ||
| Annotation::primary(param.span()).with_message("Variadic parameter used here."), | ||
| ) | ||
| .with_note("Use `func_get_args()` if you need compatibility with older PHP versions."); |
There was a problem hiding this comment.
| .with_note("Use `func_get_args()` if you need compatibility with older PHP versions."); | |
| .with_help("Use `func_get_args()` if you need compatibility with older PHP versions."); |
notes are used to provide more information, help are used to provide a solution, or a workaround.
|
We could improve support for PHP 5.x to the point where no warnings would be necessary, but achieving this would require:
When I mention making the parser version-aware, I'm primarily referring to handling elements like operator precedence. The parser would still process features from future PHP versions, provided they don't conflict with syntax from earlier versions. For example, features like property hooks can be parsed safely even if the version is set to PHP 5.4. |
azjezz
added
Priority: Medium
azjezz
force-pushed
the
main
branch
4 times, most recently
from
a8dd89b to
8c94f8c
Compare
|
@LinusU I'll be closing this PR. Mago has changed quite a lot since this PR was opened, it can't be merged anymore. and after fighting with a lot of precedence issues in the parser recently, I think adding PHP 5.x support would make the parser much more complicated. |
|
@azjezz sounds good! Sorry for never getting back to this, at the moment I'm not doing any more PHP at work, but happy to hear that your tool has evolved! 🤩 |
2 participants
I'm using an absolute ancient version of PHP at work (got handed a 10+ year old project I now need to maintain 🙈) and are constantly running into problems with me using features that aren't implemented. So this linter is actually great for me!
This PR adds the ability to configure the
php_versionall the way down to"5.4".There is still some rules missing in order to cover 100% of the features introduced between 5.4 and 7.3, but I think that this is a good start! 🐎
Please let me know if I'm doing anything wrong, which I probably am 😅
Here is a screenshot of it in action: