Update keychain to use routing for deploy and sign-message context types #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Add .claude/settings.local.json with permissions configuration for Claude Code integration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace settings.local.json with proper commands structure including pr.md and commit.md. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add DeployControllerRoute wrapper component to handle deploy context with routing - Add SignMessageRoute wrapper component to handle sign-message context with routing - Update App.tsx to include new routes for /deploy and /sign-message paths - Update Home.tsx to navigate to appropriate routes based on context type - Remove inline rendering of DeployController and SignMessage from Home.tsx switch statement - Add navigation effects to automatically route to correct paths when context changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Create dedicated route wrapper components for better separation - Implement automatic navigation when context types are set - Update app.tsx to include new routes for /deploy and /sign-message - Modify home.tsx to use navigation instead of inline rendering - Maintain backward compatibility with existing context handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
tarrencev
force-pushed
the
task/keychain-routing-update
branch
from
d93a82f to
0977b3a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…caching Replace context-based routing with Execute-pattern implementation: - Update deploy.ts and sign.ts to use URL params and callback caching instead of context - Modify connection handler to use navigate instead of setContext - Refactor DeployControllerRoute and SignMessageRoute to parse URL params - Remove automatic navigation from Home component (no longer needed) - Use callback storage/retrieval system for resolver functions - Add proper cleanup on component unmount - Follow exact same pattern as Execute component for consistency This resolves the issue of using context objects in route components by caching resolvers and passing data via URL parameters instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.