feat(session): spending limit step for register session #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| setError(e as Error); | ||
| } finally { | ||
| setIsConnecting(false); | ||
| } |
There was a problem hiding this comment.
Registration error swallowing prevents display in ExecutionContainer
The onRegisterSession function catches errors but does not re-throw them, causing the ExecutionContainer to assume the operation succeeded. Consequently, errors occurring during registration are swallowed and not displayed to the user on the summary page, as the local error state is only consumed by the non-rendered SpendingLimitPage.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces a spending-limit step into the RegisterSession flow and hardens transaction handling.
SpendingLimitPagegated byhasApprovalPolicies; verified sessions start at"spending-limit", otherwise"summary"defaultStep,stepstate, andhandleSpendingLimitConfirmto proceedisConnectinganderrorstate; wrapsregisterSessionin try/catch/finally and surfaces errors toSpendingLimitPageregisterSessionCalldata; unchanged wait logic but bounded by success stateshasApprovalPoliciesto detect token approval policies and route the flow accordinglyWritten by Cursor Bugbot for commit 18c191b. This will update automatically on new commits. Configure here.