Skip to content

feat: update erc20 metadata#163

Merged
bal7hazar merged 1 commit intomainfrom
feat/update-erc20-metadata
Oct 1, 2025
Merged

feat: update erc20 metadata#163
bal7hazar merged 1 commit intomainfrom
feat/update-erc20-metadata

Conversation

@bal7hazar
Copy link
Contributor

@bal7hazar bal7hazar commented Oct 1, 2025

Note

Adds ERC20 metadata for Dungeon Ticket (TICKET) and updates SURVIVOR token logo URL.

  • ERC20 metadata (src/generated/erc20-metadata.ts):
    • Add Dungeon Ticket (TICKET) with decimals: 18, sort_order: 1, address 0x035f581b050a39958b7188ab5c75daaa1f9d3571a0c032203038c898663f31f8, and logo_url.
    • Update SURVIVOR logo_url to https://imagedelivery.net/0xPAQaDtnQhBs8IzYRIlNg/399cb277-f675-4efe-97fb-fac94a236a00/logo.

Written by Cursor Bugbot for commit 01a0c56. This will update automatically on new commits. Configure here.

@claude
Copy link

claude bot commented Oct 1, 2025

Claude finished @bal7hazar's task —— View job


PR Review Complete ✅

I've reviewed the ERC20 metadata update PR and submitted my feedback.

Todo List:

  • Check for existing reviews and comments
  • Create pending review
  • Get PR diff and analyze changes
  • Review ERC20 metadata updates for accuracy
  • Add inline comments if issues found
  • Submit review with summary

Review Summary:

The PR adds proper ERC20 metadata updates including:

  • Updated logo URL for existing Survivor token
  • Added new "Dungeon Ticket" token entry

Found one minor formatting issue with a tab character in the new token's logo URL that should be fixed before merging. Otherwise, the changes follow the established metadata structure correctly.

The review has been submitted as a non-blocking comment to provide feedback while allowing the PR to proceed.


@bal7hazar bal7hazar merged commit 2cea195 into main Oct 1, 2025
3 checks passed
@bal7hazar bal7hazar deleted the feat/update-erc20-metadata branch October 1, 2025 18:28
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC20 Metadata Update Review

I've reviewed the changes to the ERC20 metadata file. Overall, the updates look good with proper token data additions and URL updates. However, I found one formatting issue:

Issues Found:

Formatting Issue in Dungeon Ticket Entry (Line 699)
The logo URL for the "Dungeon Ticket" token has a tab character at the beginning of the URL string. This should be cleaned up to avoid potential issues when the URL is parsed or used in applications:

Current: logo_url: " https://imagedelivery.net/..."
Should be: logo_url: "https://imagedelivery.net/..."

Summary of Changes:

Logo URL Update: Updated the Survivor token logo URL to use the imagedelivery.net CDN
New Token Addition: Added "Dungeon Ticket" (TICKET) token with proper metadata structure
⚠️ Minor Fix Needed: Remove tab character from the new token's logo URL

The changes follow the established metadata structure and use consistent CDN URLs. The new token entry includes all required fields (name, symbol, decimals, address, sort_order, total_supply, logo_url).

Recommendation: Fix the tab character formatting issue before merging, otherwise the changes are ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant