starlark: support thread cancellation and limits on computation (#298) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le#298) This change adds two related features: (1) asynchronous cancellation of Starlark threads (Thread.Cancel), and (2) recording and limiting of the number of abstract computation steps. Fixes issue google#252 Fixes issue google#160
pivotaljohn
reviewed
Jul 26, 2022
pivotaljohn
left a comment
pivotaljohn
left a comment
There was a problem hiding this comment.
The contents of the PR are just fine (it's a pure cherry-pick and looks to be complete).
There's a little out-of-the-scope-of-this-PR clean-up we need to do: make sure the tests run on this fork; they currently are not, OOTB.
Please stand by.
|
@martyspiewak we're preparing a new branch to carry this change and a number of other upstream improvements through. Do you still have an interest to see this PR through? Or would you be happy enough if we include this cherry-pick'ed commit in the process? |
Author
|
Nope! Whatever is easiest for y'all is fine with me. Thanks! |
Zebradil
pushed a commit
to mykso/starlark-go
that referenced
this pull request
Nov 7, 2025
* implement set.update method The `update` method on the `set` is defined in the Starlark specification [1] but is not present in the starlark-go implementation. This change introduces this functionality. [1] https://github.com/bazelbuild/starlark/blob/master/spec.md#setupdate * implement set.update method Fixes from @adonovan in PR * implement set.update method Fixes carvel-dev#2 from @adonovan in PR * implement set.update method Fixes carvel-dev#3 from @adonovan in PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking commit 949cc6f4 from upstream
This change adds two related features:
(1) asynchronous cancellation of Starlark threads (Thread.Cancel), and
(2) recording and limiting of the number of abstract computation steps.
Fixes issue google#252
Fixes issue google#160
Addresses: carvel-dev/ytt#593