Skip to content

feat: fix CI: fix TS18046 errors in catch blocks for strict mode compliance#21

Merged
hsluoyz merged 5 commits intobetafrom
copilot/fix-ci-error
Feb 2, 2026
Merged

feat: fix CI: fix TS18046 errors in catch blocks for strict mode compliance#21
hsluoyz merged 5 commits intobetafrom
copilot/fix-ci-error

Conversation

Copy link
Contributor

Copilot AI commented Feb 2, 2026

fix: #20

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz hsluoyz marked this pull request as ready for review February 2, 2026 16:54
Copilot AI added 2 commits February 2, 2026 16:58
Signed-off-by: GitHub Copilot <noreply@github.com>
Signed-off-by: GitHub Copilot <noreply@github.com>
Copilot AI changed the title [WIP] Fix CI error during build process Fix TS18046 errors in catch blocks for strict mode compliance Feb 2, 2026
Copilot AI requested a review from hsluoyz February 2, 2026 17:03
@hsluoyz
Copy link
Member

hsluoyz commented Feb 2, 2026

@copilot fix: https://github.com/casbin/casbin-core/actions/runs/21599498556/job/62241293474?pr=21

Run yarn run lint
  yarn run lint
  shell: /usr/bin/bash -e {0}
yarn run v1.22.22
$ eslint . --ext .js,.ts

/home/runner/work/casbin-core/casbin-core/src/util/util.ts
Error:   216:13  error  Replace `((b·as·any)·as·Array<any>).includes(a)·as·unknown)` with `b·as·any·as·Array<any>).includes(a)·as·unknown`  prettier/prettier
Error:   218:10  error  Replace `((a·in·(b·as·any))·as·unknown)` with `(a·in·(b·as·any))·as·unknown`                                        prettier/prettier

/home/runner/work/casbin-core/casbin-core/test/enforcer.test.ts
Error:   576:28  error  Replace `(98·as·unknown)` with `98·as·unknown`  prettier/prettier
Error:   577:28  error  Replace `(67·as·unknown)` with `67·as·unknown`  prettier/prettier
Error:   578:28  error  Replace `(34·as·unknown)` with `34·as·unknown`  prettier/prettier
Error:   648:28  error  Replace `(98·as·unknown)` with `98·as·unknown`  prettier/prettier
Error:   649:28  error  Replace `(67·as·unknown)` with `67·as·unknown`  prettier/prettier
Error:   650:28  error  Replace `(34·as·unknown)` with `34·as·unknown`  prettier/prettier

✖ 8 problems (8 errors, 0 warnings)
  8 errors and 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Signed-off-by: GitHub Copilot <noreply@github.com>
Copy link
Contributor Author

Copilot AI commented Feb 2, 2026

@copilot fix: https://github.com/casbin/casbin-core/actions/runs/21599498556/job/62241293474?pr=21

...

Fixed the prettier formatting issues by running yarn run fmt. The errors were pre-existing formatting issues in src/util/util.ts and test/enforcer.test.ts that have now been resolved. Commit: 6c8f5c2

@hsluoyz
Copy link
Member

hsluoyz commented Feb 2, 2026

@copilot only run against Node.js 20 in CI, drop Node.js 18

Signed-off-by: GitHub Copilot <noreply@github.com>

Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 2, 2026

@copilot only run against Node.js 20 in CI, drop Node.js 18

Updated CI workflows to only run against Node.js 20. Removed Node.js 18 from the test matrix in both ci.yml and platform_test.yml. Commit: 3e1153c

@hsluoyz hsluoyz changed the title Fix TS18046 errors in catch blocks for strict mode compliance feat: fix CI: fix TS18046 errors in catch blocks for strict mode compliance Feb 2, 2026
@hsluoyz hsluoyz merged commit 8f551a0 into beta Feb 2, 2026
16 of 18 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 2, 2026
# 1.0.0 (2026-02-02)

### Bug Fixes

* 'eval' not detected ([86e2add](86e2add))
* *matcher result should be boolean or number* for KeyGet2 ([#347](https://github.com/casbin/casbin-core/issues/347)) ([762e3fb](762e3fb))
* `getImplicitPermissionsForUser` works with rmMap ([#272](https://github.com/casbin/casbin-core/issues/272)) ([0d59239](0d59239))
* add cache to generateGFunction ([e90bed2](e90bed2))
* add casbin-cpp to supported languages. ([b856734](b856734))
* add check if the adapter implements BatchAdapter ([a415838](a415838))
* add checks fieldValues to remove filtered policy ([6e144fb](6e144fb))
* Add examples. ([5cf950a](5cf950a))
* add full supoort for `in` operator ([#310](https://github.com/casbin/casbin-core/issues/310)) ([446f8c7](446f8c7))
* Add imports and batchFileAdapter implementation. ([3804c3d](3804c3d))
* add missing await ([523ce85](523ce85))
* add support for legacy array definition method ([#313](https://github.com/casbin/casbin-core/issues/313)) ([635eece](635eece))
* Add tests for batch operations. ([e6ad7af](e6ad7af))
* Added ABAC policy logic to the private enforcer. ([c6fc487](c6fc487))
* Added util functions and util tests. ([72918bc](72918bc))
* **builtinoperators:** fix function keyMatch3 ([1245aa0](1245aa0)), closes [#214](https://github.com/casbin/casbin-core/issues/214)
* check adapter type ([a74314d](a74314d))
* compatible types ([58242a5](58242a5))
* created two regex expressions ([de5f2f4](de5f2f4))
* downgrade expression-eval back to v2.0.0 to avoid semantic-release failure, revert: casbin/node-casbin#222 ([8c0b1fd](8c0b1fd))
* downgrade target from ESNext to ES2017 for building esm ([7dfcf93](7dfcf93))
* EnforceEx return allow reason ([#363](https://github.com/casbin/casbin-core/issues/363)) ([0c18aa4](0c18aa4))
* **enforcer.ts:** fix deleteUser and improve deleteRole description ([1e6af16](1e6af16)), closes [#118](https://github.com/casbin/casbin-core/issues/118)
* export watcherEx ([#15](#15)) ([699c8f5](699c8f5))
* fix `in` opertor ([17f3588](17f3588))
* fix buildRoleLinks to isolate groups ([0fb6ae7](0fb6ae7))
* fix CasbinJsGetPermissionForUser() ([#251](https://github.com/casbin/casbin-core/issues/251)) ([98c11f1](98c11f1))
* fix cherry-pick ([242ba50](242ba50))
* fix error overloading for role manager ([#319](https://github.com/casbin/casbin-core/issues/319)) ([e69450b](e69450b))
* fix errror type ([dc9e5b5](dc9e5b5))
* fix library ([164a29a](164a29a))
* fix logic error and add unittests ([e36cc23](e36cc23))
* fix unexpected parser action ([3074fa9](3074fa9))
* getImplicitPermissionsForUser missing domain parameter ([584624c](584624c))
* ignore print model ([f426131](f426131))
* improve load policy line ([9f12511](9f12511))
* improve tokens separator ([687e96f](687e96f))
* improve update into adapter before model ([0e9ccc6](0e9ccc6))
* Merge conflicts. ([7179b17](7179b17))
* **rbac:** fix defaultRoleManager hasRole method ([#211](https://github.com/casbin/casbin-core/issues/211)) ([4f3ba65](4f3ba65))
* remove lodash ([293a852](293a852))
* remove unused import ([2f8801c](2f8801c))
* remove use spread operator with await in array ([6e4f876](6e4f876))
* rename StringAdapter to MemoryAdapter ([0b1019a](0b1019a))
* **replaceeval:** add third param to replaceEval and only replace eval() w/ matching ruleName ([#316](https://github.com/casbin/casbin-core/issues/316)) ([bd4f5bf](bd4f5bf)), closes [#315](https://github.com/casbin/casbin-core/issues/315)
* stackoverflow in getImplicitRolesForUser ([d0fc49f](d0fc49f))
* support comments after expression ([c97cb26](c97cb26))
* Support for loadIncrementalFilteredPolicy ([72c2001](72c2001))
* support pattern function in 3rd args of g ([#199](https://github.com/casbin/casbin-core/issues/199)) ([27005f8](27005f8))
* tests. ([4da5291](4da5291))
* transfer from micromatch to picomatch ([#264](https://github.com/casbin/casbin-core/issues/264)) ([6be1b06](6be1b06))
* update casbinJsGetPermissionForUser for v0.1.0 Casbin.js ([#186](https://github.com/casbin/casbin-core/issues/186)) ([6c277e8](6c277e8))
* update expression-eval ([95de296](95de296))
* use csv-like format ([3b54c93](3b54c93))
* use minimatch instead of picomatch ([90e7128](90e7128))

### Features

* [#357](https://github.com/casbin/casbin-core/issues/357) Support keyMatch5 ([#359](https://github.com/casbin/casbin-core/issues/359)) ([c8195db](c8195db))
* add addMatchingFunc to DefaultRoleManager ([cc04e65](cc04e65))
* add BuildIncrementalRoleLinks ([b565005](b565005))
* add casbinJsGetPermissionForUser ([30ae126](30ae126))
* add enforceEx() ([#271](https://github.com/casbin/casbin-core/issues/271)) ([762efd9](762efd9))
* add getImplicitUsersForPermission ([ad9df14](ad9df14))
* add glob pattern to built-in function ([8415fc2](8415fc2))
* add initRmMap ([87f8011](87f8011))
* add keyGet and keyGet2 ([#302](https://github.com/casbin/casbin-core/issues/302)) ([36e83cf](36e83cf))
* Add lazyload option at enforcer init method ([#289](https://github.com/casbin/casbin-core/issues/289)) ([e858dcb](e858dcb))
* add named addMatchingFunc ([65d3a26](65d3a26))
* add policyArrayToString and policyStringToArray to util ([0f66bc1](0f66bc1))
* add priority_policy_explicit support ([#250](https://github.com/casbin/casbin-core/issues/250)) ([763c18e](763c18e))
* add support for `in` operator ([a44c6a9](a44c6a9))
* add sync mode ([70e4e12](70e4e12))
* add unittest ([3cd5b73](3cd5b73))
* add updatePolicy() ([#234](https://github.com/casbin/casbin-core/issues/234)) ([a3218f1](a3218f1)), closes [#235](https://github.com/casbin/casbin-core/issues/235)
* add WatcherEX interface ([#13](#13)) ([e0079fb](e0079fb))
* addPoliciesWithAffected & removePoliciesWithAffected ([#12](#12)) ([57fcebd](57fcebd))
* avoid miss initialize() ([1394e8d](1394e8d))
* **batchenforce:** added batchEnforce ([#338](https://github.com/casbin/casbin-core/issues/338)) ([56e55bd](56e55bd)), closes [#321](https://github.com/casbin/casbin-core/issues/321)
* call watcherEx methods ([#16](#16)) ([b7ce2a9](b7ce2a9))
* changing TypeScript target from ES6 to ES2017 ([6f4f50f](6f4f50f))
* controls whether to automatically notify Watcher ([2ce07c2](2ce07c2))
* enforcer reactjs test ([#2](#2)) ([a111a1a](a111a1a))
* enforceSync ([ff41f0a](ff41f0a))
* Extend multiple sections type of escapeAssertion ([#180](https://github.com/casbin/casbin-core/issues/180)) ([33c784c](33c784c))
* fix and update CI scripts ([#24](#24)) ([c637584](c637584))
* fix CI: fix TS18046 errors in catch blocks for strict mode compliance ([#21](#21)) ([4ef4abd](4ef4abd))
* getAllUsersByDomain, getFieldIndex ([#14](#14)) ([99f7735](99f7735))
* getImplicitUsersForRole ([#341](https://github.com/casbin/casbin-core/issues/341)) ([ebfaede](ebfaede))
* implement csv parser ([968a232](968a232))
* implement string adapater ([0c59cae](0c59cae))
* implementation cachedEnforcer ([0ace1a6](0ace1a6))
* improve effector for improve performance ([57de7b2](57de7b2))
* improve README ([2522ae8](2522ae8))
* modernize CI workflows and README badges, regenerate yarn.lock ([#19](#19)) ([e48735c](e48735c))
* Multiple sections type ([cc58c57](cc58c57))
* RBAC with Domains API ([3e38bb5](3e38bb5))
* **rbac:** add `getUsersForRoleInDomain` & `getRolesForUserInDomain` ([#351](https://github.com/casbin/casbin-core/issues/351)) ([c787b12](c787b12)), closes [#304](https://github.com/casbin/casbin-core/issues/304)
* synchronized enforcer ([ecec514](ecec514))
* use new license format ([284d2a4](284d2a4))

### improvement

* convert all management_api to async function ([e9f4d38](e9f4d38))

### BREAKING CHANGES

* **model** addPolicies, removePolicies and removeFilteredPolicy returns [boolean, string[][]]
* - provides a new interface for Effector
* see #
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] fix CI error

3 participants