feat: add vcpkg support with proper CMake package config#265
Open
feat: add vcpkg support with proper CMake package config#265
Conversation
|
|
- Add proper install(TARGETS) command for the casbin library - Add install(EXPORT) to generate and install CMake config files - Create casbinConfig.cmake.in for proper package discovery - Use GNUInstallDirs for standard installation paths - Change include directories and link libraries from PRIVATE to PUBLIC - Add generator expressions for BUILD_INTERFACE and INSTALL_INTERFACE - Create casbinConfigVersion.cmake with version compatibility checking - All tests pass successfully Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add casbin-cpp to vcpkg
feat: add vcpkg support with proper CMake package config
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26884
Description
Adds proper CMake installation infrastructure to enable vcpkg packaging. The repository previously only exported targets to the build tree, preventing vcpkg from creating a functional port.
Changes:
GNUInstallDirsandCMakePackageConfigHelpersPRIVATEtoPUBLICwith generator expressions for build/install interface separationnlohmann_jsonResult:
Consumers can now use standard CMake discovery:
The library installs to:
${CMAKE_INSTALL_LIBDIR}/casbin.a${CMAKE_INSTALL_INCLUDEDIR}/casbin/${CMAKE_INSTALL_LIBDIR}/cmake/casbin/All 74 tests pass. vcpkg port can now be created using standard CMake build/install workflow.
Screenshots/Testimonials
N/A
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.