feat: fix CI error by removing --fix flag from lint script#297
Merged
feat: fix CI error by removing --fix flag from lint script#297
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI error in workflow
Fix CI error by removing --fix flag from lint script
Oct 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
# [1.0.0](v0.5.1...v1.0.0) (2025-10-12) ### Features * fix CI error by removing --fix flag from lint script ([#297](#297)) ([4b6eccd](4b6eccd)) * fix CI error by requiring Node.js 20+ ([#300](#300)) ([b598665](b598665)) * fix CI error by updating to Node.js 20 ([1a3ce51](1a3ce51)) * fix CI error by updating to Node.js 20 in semantic-release ([#295](#295)) ([32fd7ae](32fd7ae)) * fix webpack 5 compatibility issue in webpack.base.js ([#293](#293)) ([2f857e2](2f857e2)) * regenerate yarn.lock ([18ff623](18ff623)) * trigger v1.0.0 major release ([#291](#291)) ([1153e94](1153e94)) * update Node.js version to 18 and 20 in CI ([#289](#289)) ([f14072a](f14072a)) * Update README badges ([#287](#287)) ([971e664](971e664)) ### BREAKING CHANGES * trigger v1.0.0 major release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI workflow was failing during the lint step because the
lintscript inpackage.jsonincluded the--fixflag. Using--fixin CI environments is problematic because:Solution
Updated the
package.jsonscripts to separate checking from fixing:This follows the standard practice where:
yarn run lintto verify code quality without modifying filesyarn run lint:fixlocally to automatically fix linting issuesVerification
--fixflagFixes the CI error referenced in #[issue_number]
Original prompt
Fixes #296
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.