feat: fix panic on empty Events array in etcd watch response#36
Merged
feat: fix panic on empty Events array in etcd watch response#36
Conversation
|
|
Add checks for IsProgressNotify() and empty Events slice to prevent panic when accessing res.Events[0] Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix panic when etcd watcher receives empty events
Fix panic on empty Events array in etcd watch response
Jan 13, 2026
hsluoyz
added a commit
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etcd watch responses can contain progress notifications or empty event arrays, causing
res.Events[0]to panic with index out of bounds.Changes
IsProgressNotify()to skip health check/keep-alive messagesres.Events[0]to handle empty arraysWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
go.etcd.io/update-job-proxy /update-job-proxy -c=4(dns block)/update-job-proxy /update-job-proxy DROP ache/go/1.24.11/--global test -e ntrust_Root_Certgit@github.com/ ache/go/1.24.11//usr/share/ca-certificates/mozilla/SecureTrust_CA.crt(dns block)go.googlesource.com/update-job-proxy /update-job-proxy -c=4(dns block)/update-job-proxy /update-job-proxy DROP ache/go/1.24.11/--global test -e ntrust_Root_Certgit@github.com/ ache/go/1.24.11//usr/share/ca-certificates/mozilla/SecureTrust_CA.crt(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.