feat: add detection for more model errors#485
Open
HashCookie wants to merge 4 commits intocasbin:masterfrom
Open
feat: add detection for more model errors#485HashCookie wants to merge 4 commits intocasbin:masterfrom
HashCookie wants to merge 4 commits intocasbin:masterfrom
Conversation
Member
|
@nodece @Shivansh-yadav13 please review |
hsluoyz
requested changes
Sep 29, 2024
| const key = line.substring(0, equalIndex); | ||
| const value = line.substring(equalIndex + 1); | ||
| this.addConfig(section, key.trim(), value.trim()); | ||
| const key = line.substring(0, equalIndex).trim(); |
Member
There was a problem hiding this comment.
Extract all grammar checking code into a "validator"
rtm-ctrlz
reviewed
Dec 28, 2024
|
|
||
| // Verify operator in matcher | ||
| public static validateMatcherOperators(value: string): void { | ||
| const invalidOperators = /(?<![&|])&(?!&)|(?![&|])\|(?!\|)|&{3,}|\|{3,}/g; |
There was a problem hiding this comment.
This function is using same RegExp as validateMatcher, without any reference but just as a copy - that potentially could cause a mistake in future (when RegExp will be changed in one place, but not both).
Also this kind of RegExp (especialy LookBehind) has limited support on a not so old browsers like iOS 16 (<16.4), that could lead developers to patching casbin to use with such browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:casbin/casbin-editor#162
