Support wildcard domains in getImplicitPermissionsForUser and getImplicitRolesForUser#529
Open
Support wildcard domains in getImplicitPermissionsForUser and getImplicitRolesForUser#529
Conversation
|
|
Pull Request Test Coverage Report for Build 20072651589Details
💛 - Coveralls |
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
…ort wildcard domains Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Co-authored-by: mserico <140243407+mserico@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add role hierarchy setup with Casbin
Support wildcard domains in getImplicitPermissionsForUser and getImplicitRolesForUser
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getImplicitPermissionsForUser()andgetImplicitRolesForUser()only matched exact domains, failing to retrieve roles/permissions defined with wildcard domain (*). This prevented role hierarchy patterns where abstract roles define permissions globally and concrete roles inherit them per-domain.Changes
Extended domain matching logic:
getImplicitRolesForUser()now queries both the specific domain and wildcard domain*getImplicitPermissionsForUser()now retrieves policies from both the specific domain and wildcard domain*This aligns with the matcher behavior:
g(r.sub, p.sub, r.dom) || g(r.sub, p.sub, '*')Example
With this setup:
Previously:
Now:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.