Ensure template is recompiled when template file changes#65
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the template reload mechanism to ensure automatic recompilation when template files change. Previously, templates were pre-parsed into tokens at macro expansion time, which meant changes to template files wouldn't trigger recompilation. The new approach stores the original template string using include_str!() for file-based templates, creating a compile-time dependency that Cargo tracks for automatic recompilation.
Key changes:
- Replaced
TOKENSconstant withTEMPLATEconstant storing the original template string - Split
Parseerror intoParseNewandParseOldfor clearer error messages - Template parsing now happens at runtime in the
reload()method instead of at compile time
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/reload.rs | Splits Parse error into ParseNew and ParseOld variants for better error context |
| src/lib.rs | Replaces TOKENS const with TEMPLATE const; updates reload() to parse templates at runtime |
| crates/boilerplate-macros/src/template.rs | Removes TOKENS generation logic; generates TEMPLATE const using Source's ToTokens impl |
| crates/boilerplate-macros/src/source.rs | Implements ToTokens for Source, using include_str!() for file paths to enable automatic recompilation |
| crates/boilerplate-macros/src/lib.rs | Adds ToTokens and TokenStreamExt imports needed for source.rs implementation |
| crates/boilerplate-macros/src/implementation.rs | Removes unused tokens field from Implementation struct |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.