Skip to content

feat: provide default deps #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: provide default deps #13

wants to merge 6 commits into from

Conversation

alexeagle
Copy link

@alexeagle alexeagle commented Oct 3, 2024 •
edited
Loading

Alternative to #10 which I think is less brittle and follows practices we learned in many other rulesets.

Tested by inserting this into a repo generated with aspect init (I'm working to polish up https://github.com/aspect-build/aspect-workflows-template so developers never need to touch BUILD files)

@alexeagle
Copy link
Author

Note, I actually need this to stamp out an aspect_rules_py#py_test so that debugging works in the editor. Maybe I'll just port your macro into our ruleset - would you be okay with that @caseyduquettesc ?

alexeagle added a commit to aspect-build/rules_py that referenced this pull request Oct 3, 2024
@alexeagle
feat: port pytest_test macro
95ad08c 
Comes from caseyduquettesc/rules_python_pytest#13
It's much easier to properly gazelle-generate a BUILD file in this shape
rather than the awkward way you're forced to hold our py_pytest_main.
@alexeagle alexeagle mentioned this pull request Oct 3, 2024
Merged
@caseyduquettesc
Copy link
Owner

Note, I actually need this to stamp out an aspect_rules_py#py_test so that debugging works in the editor. Maybe I'll just port your macro into our ruleset - would you be okay with that @caseyduquettesc ?

For sure. Not sure what license is in here, but feel free to contribute or copy or simply make it obsolete!

caseyduquettesc
caseyduquettesc approved these changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@caseyduquettesc caseyduquettesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. Big QoL win!

@alexeagle
Copy link
Author

@caseyduquettesc needs fresh approve to trigger tests again

@alexeagle
Copy link
Author

For next steps - let's make some more improvements here so I'm not in the loop on aspect-build/rules_py#401

@alexeagle
Copy link
Author

I shouldn't have committed changes to MODULE.bazel.lock, could you bump CI again?

alexeagle added a commit to aspect-build/rules_py that referenced this pull request Feb 13, 2025
@alexeagle
feat: port pytest_test macro (#401)
6ad4667 
Comes from
caseyduquettesc/rules_python_pytest#13 It's much
easier to properly gazelle-generate a BUILD file in this shape rather
than the awkward way you're forced to hold our py_pytest_main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyduquettesc caseyduquettesc caseyduquettesc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @caseyduquettesc