Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to avoid prerequisite of tests having to run in a host application. #232

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

michael-zimmermann
Copy link
Contributor

See issue #229

@chwo
Copy link

chwo commented Feb 3, 2025

@RoyalPineapple Pinging you since you published the last releases.

I am experiencing the same issue that the accessibilityImage assertion crashes when run inside SPM. I can confirm that this is solved by this PR so I would love to see that fix merged. Is there anything blocking this?

@albsala-backmarket
Copy link

Hi there! Is there any progress here? We'd appreciate if this is fixed. Thank you!
cc @RoyalPineapple @NickEntin

@RoyalPineapple RoyalPineapple self-requested a review March 13, 2025 10:45
Copy link
Collaborator

@RoyalPineapple RoyalPineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable change. I don't have any objection to this being configurable.

@RoyalPineapple RoyalPineapple linked an issue Mar 13, 2025 that may be closed by this pull request
@albsala-backmarket
Copy link

Hey @RoyalPineapple thank you for the approval ❤️!
Not sure if we need something else to merge this PR and close the issue?

@RoyalPineapple RoyalPineapple merged commit 5bc3728 into cashapp:master Mar 14, 2025
6 checks passed
@NickEntin
Copy link
Collaborator

Apologies for the slow response here. This change feels like it introduces a pretty big footgun into the library. As @szotp's example in the linked issue illustrates, the behavior when running outside a host application is unpredictable and can give some very deceptive test results. While it's definitely an unfortunate requirement, I'd highly recommend reverting this change, since setting this parameter to false essentially means you can't trust the correctness of the resulting snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for packages without host application.
5 participants