Adjusting sort order to more closely match VoiceOver #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalPineapple
force-pushed
the
alex/SortOrder
branch
from
aba6150 to
b6082db
Compare
RoyalPineapple
force-pushed
the
alex/SortOrder
branch
from
64d9dc6 to
e7b6650
Compare
RoyalPineapple
changed the title
kyleve
approved these changes
Mar 13, 2025
meherkasam
reviewed
Mar 13, 2025
There was a problem hiding this comment.
If path down is 8 pt below path unchanged, shouldn't fifth come before fourth?
There was a problem hiding this comment.
path is completely ignored for these calculations. Thats the point i was trying to make with the snapshot. Adjusting the frames changes the order, adjusting the path does not.
Perhaps I can make the header and footer labels say this directly.
You can try this view controller out it out on device if you'd like. It blew my mind.
There was a problem hiding this comment.
Oh got it! Sorry I missed this line from your description: "VoiceOver element sorting always uses accessibility frames, even when a path is present."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #221 which points out two subtle details in VoiceOver's positional element sorting.
I've confirmed this behavior on device as far back as iOS15. This does not appear to be a change in VoiceOver behavior from any previous versions rather a detail that has been overlooked in our implementation. So we won't need to fork the behavior by version.
This also falls under the 'Correcting Accessibility Element Descriptions' versioning guidance making this change a minor version bump.