Fix false positive activation points for SwiftUI elements#315
Merged
RoyalPineapple merged 2 commits intomainfrom Feb 11, 2026
Merged
Fix false positive activation points for SwiftUI elements#315RoyalPineapple merged 2 commits intomainfrom
RoyalPineapple merged 2 commits intomainfrom
Conversation
RoyalPineapple
force-pushed
the
alex/activation-testing
branch
from
f38df13 to
7c741cc
Compare
RoyalPineapple
requested review from
khanlou,
kyleve,
meherkasam,
meherkasam-square and
soroushsq
as code owners
soroushsq
approved these changes
Feb 11, 2026
Collaborator
soroushsq
left a comment
soroushsq
left a comment
There was a problem hiding this comment.
Code looks fine, do we need a test for this?
Test the four key scenarios: - Zero frame + zero activation point → treated as default - Zero frame + valid path + valid activation point → treated as default - Normal frame + center activation point → treated as default - Normal frame + custom activation point → not default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftUI AccessibilityNode elements report accessibilityFrame as .zero but provide valid accessibilityPath geometry. This caused the parser to incorrectly mark all such elements as having overridden activation points.
Adds effectiveAccessibilityFrame(for:) to fall back to accessibilityPath.bounds when accessibilityFrame is empty. Updates defaultActivationPoint(for:) to use the effective frame. Adds usesDefaultActivationPoint(element:activationPoint:screenScale:) which fast-paths when both activation point and frame are zero.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com