Repository navigation
Fix shell redirect to suppress stdout with --print - #619
Merged
Merged
Conversation
--print
alecthomas
approved these changes
Sep 9, 2026
alecthomas
enabled auto-merge (squash)
September 9, 2026 03:21
auto-merge was automatically disabled
September 9, 2026 05:35
Head branch was pushed to by a user without write access
alecthomas
approved these changes
Sep 15, 2026
alecthomas
enabled auto-merge (squash)
September 15, 2026 21:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The root shim's self-bootstrap fallback pipes
install.shintobashwithout redirecting stdout. Since the shim is meant to run insideeval "$(hermit shell-hooks --print --zsh)", install.sh's progress messages geteval'd as shell commands on any machine whereHERMIT_EXEisn't bootstrapped yet - polluting the shell with failed eval's. Subsequent opens are fine as the binary is installed correctlyFix
Redirect that output to stderr (
bash 1>&2) in bothfiles/install.sh.tmplandcmd/geninstaller/install.sh.tmpl, with a regression test covering the self-bootstrap path.Test