Open
Conversation
- Add retries(maxAttempts) and noRetries() methods to Transacter interface - Implement retry logic in RealTransacter using misk.backoff.retry - Use DefaultExceptionClassifier for database-specific retry decisions - Pass DataSourceConfig to RealTransacter for database type awareness - Add unit tests for retry behavior This brings JDBC transacter in line with Hibernate's retry support, enabling services using raw JDBC (like outbox and permit) to benefit from automatic transaction retries on recoverable errors.
c07a4c1 to
a5ebd19
Compare
ThePumpingLemma
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
retries(maxAttempts)andnoRetries()methods to the JDBCTransacterinterface, bringing it in line with Hibernate and jOOQ retry support.