Skip to content

add initial component tests [WIP]#134

Draft
mr-zwets wants to merge 1 commit intomainfrom
component-tests
Draft

add initial component tests [WIP]#134
mr-zwets wants to merge 1 commit intomainfrom
component-tests

Conversation

@mr-zwets
Copy link
Member

No description provided.

@rnbrady
Copy link
Contributor

rnbrady commented Jan 23, 2026

Nice work. Two thoughts:

  1. Some test libraries encourage testing what the user expects rather than what the developer expects. This avoids adding lots of testing labels. A somewhat trivial example:
Screenshot 2026-01-23 at 10 08 54

  1. Having two vitest config files is a bit of a kludge. I think this was standard practice with vitest v3 but in v4 there's a cleaner way to do it with a single file, which is what I did here:
Screenshot 2026-01-23 at 10 18 48

Because there's no browser.enabled: true in the config, the browser checks won't run by default so you can do:

vitest or
vitest --browser

However in the case of Cashonize perhaps all tests should just run in the browser by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants