Add E2E tests for WalletConnect using Playwright#172
Open
rnbrady wants to merge 12 commits intocashonize:mainfrom
Open
Add E2E tests for WalletConnect using Playwright#172rnbrady wants to merge 12 commits intocashonize:mainfrom
rnbrady wants to merge 12 commits intocashonize:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Playwright-based E2E test setup for WalletConnect by introducing a minimal Vue test dApp, Playwright configuration, and CI wiring to run the E2E suite alongside existing lint/type/unit tests.
Changes:
- Add Playwright E2E tests covering WalletConnect connect/sign/cancel/disconnect flows.
- Add a standalone Vue/Vite “test dApp” used by the E2E tests.
- Wire E2E execution into
package.jsonscripts and GitHub Actions CI.
Reviewed changes
Copilot reviewed 14 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds Playwright packages to the root Yarn v1 lockfile. |
| package.json | Adds test:e2e and test:e2e:ui scripts and @playwright/test dev dependency. |
| vitest.config.ts | Excludes test/e2e/** from Vitest runs. |
| tsconfig.json | Formatting-only change. |
| quasar.config.ts | Excludes test/e2e/test-dapp from Quasar-generated TS config checking. |
| test/e2e/playwright.config.ts | New Playwright config that starts the wallet dev server and the test dApp server. |
| test/e2e/walletconnect.test.ts | New Playwright E2E test suite for WalletConnect flows. |
| test/e2e/test-dapp/package.json | New minimal Vue/Vite test dApp package definition. |
| test/e2e/test-dapp/vite.config.ts | Vite config for the test dApp (fixed port). |
| test/e2e/test-dapp/tsconfig.json | TypeScript config for the test dApp. |
| test/e2e/test-dapp/index.html | Test dApp HTML entrypoint. |
| test/e2e/test-dapp/src/main.ts | Vue bootstrap for the test dApp. |
| test/e2e/test-dapp/src/App.vue | Test dApp UI + WalletConnect request logic and TX fixture. |
| test/e2e/test-dapp/README.md | Usage notes for running the test dApp standalone. |
| test/e2e/test-dapp/.gitignore | Ignores test dApp build artifacts and deps. |
| test/e2e/test-dapp/yarn.lock | Adds a separate lockfile for the test dApp (currently Yarn Berry format). |
| .gitignore | Ignores .env* and Playwright test-results/. |
| .github/workflows/ci.yml | Adds yarn test:e2e to CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Closes #127 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
If the environment or .env contains E2E_SEED_PHRASE this will be used to test transaction signing. Otherwise that test will be skipped.
Correction: Turns out you can send an arbitrary tx to cashonize for signing with
broadcast: falseand it will sign it. So we don't need a funded chipnet seed phrase for the tests. However, such the seed phrase will be useful for future e2e tests so I have left support for it in an simply removed the condition so that signTransaction is tested either way.