Skip to content

NOJIRA: Remove obsolete action #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tsonov merged 3 commits into from
Mar 27, 2025
Merged

NOJIRA: Remove obsolete action #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
970408d
Remove obsolete action
Tsonov Mar 27, 2025
d539dbb
Remove from handlers list.
Tsonov Mar 27, 2025
f6a3fc8
Remove from API types
Tsonov Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions internal/actions/approve_csr_handler.go
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions internal/castai/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ type ClusterAction struct {
ActionDrainNode *ActionDrainNode `json:"actionDrainNode,omitempty"`
ActionPatchNode *ActionPatchNode `json:"actionPatchNode,omitempty"`
ActionCreateEvent *ActionCreateEvent `json:"actionCreateEvent,omitempty"`
ActionApproveCSR *ActionApproveCSR `json:"actionApproveCsr,omitempty"`
ActionChartUpsert *ActionChartUpsert `json:"actionChartUpsert,omitempty"`
ActionChartUninstall *ActionChartUninstall `json:"actionChartUninstall,omitempty"`
ActionChartRollback *ActionChartRollback `json:"actionChartRollback,omitempty"`
Expand Down Expand Up @@ -62,9 +61,6 @@ func (c *ClusterAction) Data() interface{} {
if c.ActionCreateEvent != nil {
return c.ActionCreateEvent
}
if c.ActionApproveCSR != nil {
return c.ActionApproveCSR
}
if c.ActionChartUpsert != nil {
return c.ActionChartUpsert
}
Expand Down Expand Up @@ -168,13 +164,6 @@ type ActionEvictPod struct {
PodName string `json:"podName"`
}

// TODO clean up after proper handling unknown actions https://castai.atlassian.net/browse/KUBE-1036.
type ActionApproveCSR struct {
NodeName string `json:"nodeName"`
NodeID string `json:"nodeId"`
AllowAutoApprove *bool `json:"allowAutoApprove,omitempty"`
}

type ActionPatchNode struct {
NodeName string `json:"nodeName"`
NodeID string `json:"nodeId"`
Expand Down
1 change: 0 additions & 1 deletion internal/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ func NewService(
reflect.TypeOf(&castai.ActionDrainNode{}): actions.NewDrainNodeHandler(log, clientset, cfg.Namespace),
reflect.TypeOf(&castai.ActionPatchNode{}): actions.NewPatchNodeHandler(log, clientset),
reflect.TypeOf(&castai.ActionCreateEvent{}): actions.NewCreateEventHandler(log, clientset),
reflect.TypeOf(&castai.ActionApproveCSR{}): actions.NewApproveCSRHandler(),
reflect.TypeOf(&castai.ActionChartUpsert{}): actions.NewChartUpsertHandler(log, helmClient),
reflect.TypeOf(&castai.ActionChartUninstall{}): actions.NewChartUninstallHandler(log, helmClient),
reflect.TypeOf(&castai.ActionChartRollback{}): actions.NewChartRollbackHandler(log, helmClient, cfg.Version),
Expand Down
Loading