Skip to content

NOJIRA: Don't wait for non-running pods when deleting node. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tsonov merged 1 commit into from
Apr 10, 2025
Merged

NOJIRA: Don't wait for non-running pods when deleting node. #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/actions/delete_node_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"reflect"
"time"

"github.com/samber/lo"
"github.com/sirupsen/logrus"
v1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
Expand Down Expand Up @@ -158,7 +159,12 @@ func (h *DeleteNodeHandler) Handle(ctx context.Context, action *castai.ClusterAc
if err != nil {
return true, fmt.Errorf("unable to list pods for node %q err: %w", req.NodeName, err)
}
if len(pods.Items) > 0 {

runningPods := lo.Filter(pods.Items, func(p v1.Pod, _ int) bool {
// We don't care about non-running pods, node is being deleted anyway.
return p.Status.Phase == v1.PodRunning
})
if len(runningPods) > 0 {
return true, fmt.Errorf("waiting for %d pods to be terminated on node %v", len(pods.Items), req.NodeName)
}
// Check if there are any volume attachments left for the node, but don't block on waiting for them.
Expand Down
Loading