KUBE-1216: add provider id check to exclude node name reusing#188
Merged
KUBE-1216: add provider id check to exclude node name reusing#188
Conversation
…de node name reusing
ValyaB
changed the title
ValyaB
changed the title
…de node name reusing
aldor007
reviewed
Jul 11, 2025
aldor007
reviewed
Jul 11, 2025
aldor007
reviewed
Jul 11, 2025
aldor007
reviewed
Jul 11, 2025
aldor007
reviewed
Jul 11, 2025
aldor007
reviewed
Jul 11, 2025
Tsonov
reviewed
Jul 14, 2025
Tsonov
reviewed
Jul 14, 2025
Tsonov
reviewed
Jul 14, 2025
Tsonov
reviewed
Jul 14, 2025
| log.Info("node not found, skipping draining") | ||
| return nil | ||
| } | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Should we treat mismatch as if it was not found (i.e. skip drain; no error)? It is more consistent with how Delete handles this 🤔 And in case node was reused during DeleteNode in EP, we'd get error here, even though we couldn't really prevent it.
Contributor
Author
There was a problem hiding this comment.
added does not match - skip returning error
aldor007
approved these changes
Jul 14, 2025
Tsonov
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.