CSU-3481: Add new bootstrap requesting user for CSR to auto-approval#192
Merged
CSU-3481: Add new bootstrap requesting user for CSR to auto-approval#192
Conversation
dvoros-castai
approved these changes
Jun 30, 2025
krystiancastai
approved these changes
Jun 30, 2025
Makefile
Outdated
| ## build: Build the binary for the specified architecture and create a Docker image. Usually this means ARCH=amd64 should be set if running on an ARM machine. Use `go build .` for simple local build. | ||
| build: | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=$(ARCH) go build -ldflags "-s -w" -o bin/castai-cluster-controller-$(ARCH) . | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=$(ARCH) go build -ldflags "-s -w -X main.Version=v100.100.100" -o bin/castai-cluster-controller-$(ARCH) . |
Contributor
Author
There was a problem hiding this comment.
no, good catch 🤦 I didn't exclude it while testing (we don't handle "local" build correctly on kubecast and try to schedule the old CSR approval action...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GKE 1.33 it was observed that the user has changed, causing CSR to not be recognized and ignored. Node was stuck unable to reach apiserver due to this.
Also made the "skip" log info level as most customers deploy at info and it was impossible to see this was happening live.