Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
reflector initializes informers. It now expects watchers to implement the WatchList
protocol (sending Added events followed by a Bookmark).
metrics API doesn't support native watching. This shim doesn't implement the WatchList
protocol, causing the reflector to enter a retry loop where it repeatedly creates and
stops watchers, never syncing. The repeated Stop() calls also triggered a close of closed
channel panic.
IsWatchListSemanticsUnSupported(), so the reflector falls back to the classic list+watch
flow.
Testing
✅ Lint passed
✅ Tests passed with race detector (go test ./... -race)