Skip to content

feat: add castai_workload_custom_metrics_data_source resource#141

Merged
damiankaminski merged 1 commit intomainfrom
dk/workload-custom-metrics-data-source
Mar 31, 2026
Merged

feat: add castai_workload_custom_metrics_data_source resource#141
damiankaminski merged 1 commit intomainfrom
dk/workload-custom-metrics-data-source

Conversation

@damiankaminski
Copy link
Copy Markdown
Contributor

@damiankaminski damiankaminski commented Mar 31, 2026

Summary

  • Add castai_workload_custom_metrics_data_source resource to the module, allowing users to configure Prometheus custom metrics data sources via the workload_custom_metrics_data_sources variable
  • Supports presets (e.g. jvm) and manually defined PromQL metrics
  • Bump minimum provider version to >= 8.26.0

Related provider: castai/terraform-provider-castai#669

Test plan

  • terraform validate passes
  • Verify docs are correctly generated

@damiankaminski damiankaminski requested a review from a team as a code owner March 31, 2026 07:49
@damiankaminski damiankaminski marked this pull request as draft March 31, 2026 07:50
@damiankaminski damiankaminski marked this pull request as ready for review March 31, 2026 12:06
@dvoros-castai
Copy link
Copy Markdown
Member

Nit: there's no depends_on = [helm_release.castai_workload_autoscaler] here as opposed to castai/terraform-castai-eks-cluster#173, I assume that's not intentional.

Context: trying to keep these modules in sync with the goal of extracting these pieces to a shared sub-module some day. Small diffs like this will make that harder to do.

@damiankaminski
Copy link
Copy Markdown
Contributor Author

Nit: there's no depends_on = [helm_release.castai_workload_autoscaler] here as opposed to castai/terraform-castai-eks-cluster#173, I assume that's not intentional.

Context: trying to keep these modules in sync with the goal of extracting these pieces to a shared sub-module some day. Small diffs like this will make that harder to do.

Good catch! Added here and in the other PR (it was missing in 2 out of 3 PRs)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@damiankaminski damiankaminski force-pushed the dk/workload-custom-metrics-data-source branch from 545e002 to 25a66c4 Compare March 31, 2026 14:11
@damiankaminski damiankaminski merged commit 2eb823a into main Mar 31, 2026
6 checks passed
@damiankaminski damiankaminski deleted the dk/workload-custom-metrics-data-source branch March 31, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants