Standardize Helm Deployments with envFrom for CAST AI Components#479
Closed
anthonyvg9 wants to merge 3 commits intomasterfrom
Closed
Standardize Helm Deployments with envFrom for CAST AI Components#479anthonyvg9 wants to merge 3 commits intomasterfrom
anthonyvg9 wants to merge 3 commits intomasterfrom
Conversation
|
This PR has been labeled as stale due to inactivity and will be closed in 7 days if no further activity occurs. |
aldor007
approved these changes
May 23, 2025
|
This PR has been labeled as stale due to inactivity and will be closed in 7 days if no further activity occurs. |
|
This PR has been closed due to inactivity. Feel free to reopen if you are still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Helm deployment commands to:
• Use consistent envFrom blocks across all components by referencing:
• CAST_SECRET_APIKEY for API key secrets
• CAST_CONFIG_CLUSTERID for metadata configMap
• Replace hardcoded values with shell variables for clarity and reuse.
• Fix inconsistent escaping and line breaks in --set values.
• Explicitly set replicaCount for evictor and pod-pinner.
• Clean up formatting for better readability and maintainability.
Improves deployment consistency, simplifies configuration, and aligns with best practices.